-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Nuxt module does not take into account "srcDir" for client instrumentation #13330
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Comments
Thanks for already testing the experimental Nuxt SDK and filing this! We will fix this, as we want to be compatible with Nuxt 4! |
A follow-up question @max-arias: Why would you want to add the config file in the |
@s1gr1d Yeah, if I try placing just
|
Thanks for clarifying, I'll take a look! |
Hy @max-arias this seems to be no issue anymore? 🤔 I just stumbled upon this still-open issue and modified the |
@s1gr1d Hello, I had already tried installing Sentry this summer, and I encountered the issue mentioned here, along with others—it was too early. Today I decided to try again, and now everything seems to be working except for a warning at the end of the build that says:
This strongly resembles of this issue. So maybe there is a check for this file that happens too early in the script? Thanks for your help! |
@s1gr1d It looks like I was getting this warning only because I had |
Thanks for testing it and good to hear that it's working. I'll check the logging, this does not seem right. edit: Fixed it with PR #15790 |
A PR closing this issue has just been released 🚀This issue was referenced by PR #15790, which was included in the 9.9.0 release. |
Is there an existing issue for this?
How do you use Sentry?
Sentry Saas (sentry.io)
Which SDK are you using?
@sentry/nuxt
SDK Version
8.25.0
Framework Version
8.25.0
Link to Sentry event
No response
Reproduction Example/SDK Setup
No response
Steps to Reproduce
The Sentry module does not seem to take into account the
srcDir
config, it only uses thebuildDir
: https://github.com/getsentry/sentry-javascript/blob/master/packages/nuxt/src/module.ts#L30The current work around is to create a client file both under your
srcDir
(ie. /src) and in yourbuildDir
(ie /)With the upcoming Nuxt 4 change where the src files will live in another dir, we should fix this
Expected Result
We should read
sentry.client.config
from thesrcDir
without needing a copy in thebuildDir
Actual Result
rollup throws an error if there's nothing in "srcDir"
The text was updated successfully, but these errors were encountered: