Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add handled option to captureConsoleIntegration #14659

Closed
1 task done
Lms24 opened this issue Dec 11, 2024 · 1 comment · Fixed by #14664
Closed
1 task done

Add handled option to captureConsoleIntegration #14659

Lms24 opened this issue Dec 11, 2024 · 1 comment · Fixed by #14664
Assignees
@Lms24
Labels
Package: core Issues related to the Sentry Core SDK Type: Improvement

Comments

@Lms24
Copy link
Member

Lms24 commented Dec 11, 2024 •
edited
Loading

As discussed today with @mydea and @krystofwoldrich we want to eventually default to setting handled: true for captureConsole-sent events. Furthermore, we'll add an option for users to override the handled value easily.

Since switching from handled: false to true is a slight behavior break, we decided to hold off from that until we'Re working on v9. For v8 though we can introduce the option and default to false

In v9: #14669
@Lms24 Lms24 self-assigned this Dec 11, 2024
@Lms24 Lms24 mentioned this issue Dec 11, 2024
Merged
@Lms24 Lms24 added this to the 9.0.0 milestone Dec 11, 2024
@Lms24 Lms24 added Type: Improvement Package: core Issues related to the Sentry Core SDK labels Dec 11, 2024
@Lms24 Lms24 changed the title Add handled option to captureConsoleIntegration Add handled option to captureConsoleIntegration and mark events as handled by default Dec 11, 2024
@Lms24 Lms24 changed the title Add handled option to captureConsoleIntegration and mark events as handled by default Mark events from captureConsoleIntegration as handled by default Dec 11, 2024
@Lms24 Lms24 removed this from the 9.0.0 milestone Dec 11, 2024
@Lms24 Lms24 changed the title Mark events from captureConsoleIntegration as handled by default Add handled option to captureConsoleIntegration Dec 11, 2024
@Lms24 Lms24 mentioned this issue Dec 11, 2024
Closed
@github-actions GitHub Actions
Copy link
Contributor

A PR closing this issue has just been released 🚀

This issue was referenced by PR #14664, which was included in the 8.45.0 release.

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@Lms24 Lms24

Labels
Package: core Issues related to the Sentry Core SDK Type: Improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(core): Add handled option to captureConsoleIntegration getsentry/sentry-javascript
1 participant
@Lms24