Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

profiling-node should store profile_id on span rather than profile context #15405

Open
timfish opened this issue Feb 13, 2025 · 0 comments
Open
Labels
Feature: Profiling Package: profiling-node Issues related to the Sentry Profiling Node SDK Type: Improvement

Comments

@timfish
Copy link
Collaborator

timfish commented Feb 13, 2025

Description

Currently @sentry/profiling-node stores the profile_id on the isolated context:

getIsolationScope().setContext('profile', { profile_id });

This means the profile cannot be found if there are multiple versions of @sentry/core in the dependencies.

Instead can we store the profile_id on the span? There's already a property for this:

Then the integration wouldn't rely on updating any scope. In the beforeEnvelope hook we just go through the spans until we find a profile_id?

@timfish timfish added Feature: Profiling Package: profiling-node Issues related to the Sentry Profiling Node SDK Type: Improvement labels Feb 13, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Feature: Profiling Package: profiling-node Issues related to the Sentry Profiling Node SDK Type: Improvement
Projects
None yet
Development

No branches or pull requests

1 participant