profiling-node should store profile_id
on span rather than profile context
#15405
Labels
Feature: Profiling
Package: profiling-node
Issues related to the Sentry Profiling Node SDK
Type: Improvement
Description
Currently
@sentry/profiling-node
stores theprofile_id
on the isolated context:sentry-javascript/packages/profiling-node/src/integration.ts
Line 87 in ec02f84
This means the profile cannot be found if there are multiple versions of
@sentry/core
in the dependencies.Instead can we store the
profile_id
on the span? There's already a property for this:sentry-javascript/packages/core/src/types-hoist/span.ts
Line 49 in bfe7bfa
Then the integration wouldn't rely on updating any scope. In the
beforeEnvelope
hook we just go through the spans until we find aprofile_id
?The text was updated successfully, but these errors were encountered: