-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Convert @sentry/ember
addon to V2 addon format
#15835
Comments
Hey, thanks for opening this. We are currently pretty busy, so I can't really say when the team will find time to pick this up. We'd be happy to review a PR for this, though! A challenge would be that we have to remain compatible with the old format too - not sure if/how it is possible for us to publish both variants at the same time? If this is not possible in the same package, we can probably only make this change in the next major (v10), but work could be prepared for it already in advance. |
@mydea ok, good. Yes, it would maybe considered a breaking change in some cases (but also maybe not for a simple addon like this?). The V2 addon format with |
Basically, if current E2E tests using the Ember SDK pass, any change is fine 😅 (I believe). As long as compatibility remains given, we can always update! This means it has to support: Node 18+ Which is our current support policy. |
Ok, good. Backwards compatibility not be a problem then, as I believe the V2 addon format is supported by ember 3.28+. |
Problem Statement
Modern Ember build tools (
@embroider/vite
and@embroider/webpack
) benefit greatly from static, pre-built addons when bundling the app.The current
@sentry/ember
package is currently on the old ember addon-format. It works, but it is not optimized for the modern ember build tooling, as it does currently needs be processed/rewritten by@embroider
on every build.Also, it is currently sorted with warnings in the group of other legacy V1 addons when running e.g.
npx ember-addon-v2-scanner@latest
:(related to #12336, but this is more specific)
Solution Brainstorm
Here is a guide for porting an addon to the V2 format .
The text was updated successfully, but these errors were encountered: