Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Unify console instrumentation #4532

Closed
AbhiPrasad opened this issue Feb 9, 2022 · 0 comments
Closed

Unify console instrumentation #4532

AbhiPrasad opened this issue Feb 9, 2022 · 0 comments
Labels
hacktoberfest Meta: Help Wanted Package: core Issues related to the Sentry Core SDK

Comments

@AbhiPrasad
Copy link
Member

The console instrumentation in the SDK seem to duplicate code. Maybe we can find a way to unify them? We can also improve testing this way, and it may help save bundle size.

the instrumentConsole utility:

function instrumentConsole(): void {

the node Console integration: https://github.com/getsentry/sentry-javascript/blob/master/packages/node/src/integrations/console.ts

the CaptureConsole integration: https://github.com/getsentry/sentry-javascript/blob/master/packages/integrations/src/captureconsole.ts

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
hacktoberfest Meta: Help Wanted Package: core Issues related to the Sentry Core SDK
Projects
None yet
Development

No branches or pull requests

2 participants