From e84774cd7c598d6b6447ca8b45dc094858896974 Mon Sep 17 00:00:00 2001 From: Charly Gomez Date: Wed, 14 May 2025 14:35:33 +0200 Subject: [PATCH] filter manifest requests --- .../lowQualityTransactionsFilterIntegration.ts | 2 +- packages/react-router/src/server/sdk.ts | 2 +- .../server/lowQualityTransactionsFilterIntegration.test.ts | 3 ++- packages/react-router/test/server/sdk.test.ts | 2 +- 4 files changed, 5 insertions(+), 4 deletions(-) rename packages/react-router/src/server/{ => integration}/lowQualityTransactionsFilterIntegration.ts (96%) diff --git a/packages/react-router/src/server/lowQualityTransactionsFilterIntegration.ts b/packages/react-router/src/server/integration/lowQualityTransactionsFilterIntegration.ts similarity index 96% rename from packages/react-router/src/server/lowQualityTransactionsFilterIntegration.ts rename to packages/react-router/src/server/integration/lowQualityTransactionsFilterIntegration.ts index 705359eab62c..eec1cfa72403 100644 --- a/packages/react-router/src/server/lowQualityTransactionsFilterIntegration.ts +++ b/packages/react-router/src/server/integration/lowQualityTransactionsFilterIntegration.ts @@ -10,7 +10,7 @@ function _lowQualityTransactionsFilterIntegration(options: NodeOptions): { name: string; processEvent: (event: Event, hint: EventHint, client: Client) => Event | null; } { - const matchedRegexes = [/GET \/node_modules\//, /GET \/favicon\.ico/, /GET \/@id\//]; + const matchedRegexes = [/GET \/node_modules\//, /GET \/favicon\.ico/, /GET \/@id\//, /GET \/__manifest\?/]; return { name: 'LowQualityTransactionsFilter', diff --git a/packages/react-router/src/server/sdk.ts b/packages/react-router/src/server/sdk.ts index b0ca0e79bd49..43471c33129f 100644 --- a/packages/react-router/src/server/sdk.ts +++ b/packages/react-router/src/server/sdk.ts @@ -5,8 +5,8 @@ import type { NodeClient, NodeOptions } from '@sentry/node'; import { getDefaultIntegrations as getNodeDefaultIntegrations, init as initNodeSdk } from '@sentry/node'; import { DEBUG_BUILD } from '../common/debug-build'; import { SEMANTIC_ATTRIBUTE_SENTRY_OVERWRITE } from './instrumentation/util'; +import { lowQualityTransactionsFilterIntegration } from './integration/lowQualityTransactionsFilterIntegration'; import { reactRouterServerIntegration } from './integration/reactRouterServer'; -import { lowQualityTransactionsFilterIntegration } from './lowQualityTransactionsFilterIntegration'; /** * Returns the default integrations for the React Router SDK. diff --git a/packages/react-router/test/server/lowQualityTransactionsFilterIntegration.test.ts b/packages/react-router/test/server/lowQualityTransactionsFilterIntegration.test.ts index 58ddf3e215d6..3aac16d0d05d 100644 --- a/packages/react-router/test/server/lowQualityTransactionsFilterIntegration.test.ts +++ b/packages/react-router/test/server/lowQualityTransactionsFilterIntegration.test.ts @@ -2,7 +2,7 @@ import type { Event, EventType, Integration } from '@sentry/core'; import * as SentryCore from '@sentry/core'; import * as SentryNode from '@sentry/node'; import { afterEach, describe, expect, it, vi } from 'vitest'; -import { lowQualityTransactionsFilterIntegration } from '../../src/server/lowQualityTransactionsFilterIntegration'; +import { lowQualityTransactionsFilterIntegration } from '../../src/server/integration/lowQualityTransactionsFilterIntegration'; const loggerLog = vi.spyOn(SentryCore.logger, 'log').mockImplementation(() => {}); @@ -18,6 +18,7 @@ describe('Low Quality Transactions Filter Integration', () => { ['node_modules requests', 'GET /node_modules/some-package/index.js'], ['favicon.ico requests', 'GET /favicon.ico'], ['@id/ requests', 'GET /@id/some-id'], + ['manifest requests', 'GET /__manifest?p=%2Fperformance%2Fserver-action'], ])('%s', (description, transaction) => { const integration = lowQualityTransactionsFilterIntegration({ debug: true }) as Integration; const event = { diff --git a/packages/react-router/test/server/sdk.test.ts b/packages/react-router/test/server/sdk.test.ts index 57b51d16c042..fdb894299760 100644 --- a/packages/react-router/test/server/sdk.test.ts +++ b/packages/react-router/test/server/sdk.test.ts @@ -3,7 +3,7 @@ import type { NodeClient } from '@sentry/node'; import * as SentryNode from '@sentry/node'; import { SDK_VERSION } from '@sentry/node'; import { afterEach, describe, expect, it, vi } from 'vitest'; -import * as LowQualityModule from '../../src/server/lowQualityTransactionsFilterIntegration'; +import * as LowQualityModule from '../../src/server/integration/lowQualityTransactionsFilterIntegration'; import { init as reactRouterInit } from '../../src/server/sdk'; const nodeInit = vi.spyOn(SentryNode, 'init');