Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

added non default port to host if missing #558

Merged
merged 1 commit into from
Mar 5, 2018
Merged

added non default port to host if missing #558

merged 1 commit into from
Mar 5, 2018

Conversation

Powerhamster
Copy link
Contributor

No description provided.

Copy link
Collaborator

@stayallive stayallive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks solid. Could you also add a test for this?

@Powerhamster
Copy link
Contributor Author

added test

Copy link
Collaborator

@stayallive stayallive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 thanks again!

@stayallive stayallive requested a review from Jean85 March 3, 2018 19:06
@Jean85 Jean85 merged commit 6cd5114 into getsentry:releases/1.8.x Mar 5, 2018
stayallive added a commit that referenced this pull request Mar 20, 2018
Handle and add non default port to host (#558)
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants