From 1a9448c34448c587ba3a0db225c7530f6f0aa6f1 Mon Sep 17 00:00:00 2001 From: Markus Hintersteiner Date: Tue, 27 Feb 2024 20:51:23 +0100 Subject: [PATCH] fix(metrics): Replace invalid tag values with an empty string instead of _ --- sentry_sdk/metrics.py | 2 +- tests/test_metrics.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/sentry_sdk/metrics.py b/sentry_sdk/metrics.py index b52e30b6b9..2adb1192a5 100644 --- a/sentry_sdk/metrics.py +++ b/sentry_sdk/metrics.py @@ -55,7 +55,7 @@ _in_metrics = ContextVar("in_metrics", default=False) _sanitize_key = partial(re.compile(r"[^a-zA-Z0-9_/.-]+").sub, "_") -_sanitize_value = partial(re.compile(r"[^\w\d_:/@\.{}\[\]$-]+", re.UNICODE).sub, "_") +_sanitize_value = partial(re.compile(r"[^\w\d_:/@\.{}\[\]$-]+", re.UNICODE).sub, "") _set = set # set is shadowed below GOOD_TRANSACTION_SOURCES = frozenset( diff --git a/tests/test_metrics.py b/tests/test_metrics.py index d3cfd659d1..a57aeda2fa 100644 --- a/tests/test_metrics.py +++ b/tests/test_metrics.py @@ -822,7 +822,7 @@ def test_tag_normalization( assert len(m) == 3 assert m[0][4] == { - "foo-bar": "_$foo", + "foo-bar": "$foo", "release": "fun-release@1.0.0", "environment": "not-fun-env", }