Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Logging outputModulesPath twice #3308

Closed
jenskuhrjorgensen opened this issue Sep 28, 2023 · 1 comment · Fixed by #3316
Closed

Logging outputModulesPath twice #3308

jenskuhrjorgensen opened this issue Sep 28, 2023 · 1 comment · Fixed by #3316

Comments

@jenskuhrjorgensen
Copy link
Contributor

How does the following output make sense in the ModulesCollector (both saving and resolving modules to/from the same path (outputModulesPath))?

logger.info('Saving modules to', outputModulesPath);
logger.info('Resolving modules from paths', outputModulesPath);

Example output:

Sentry Logger [info]: Saving modules to /Users/johndoe/Documents/repos/sentry-test-logger/android/app/src/main/assets/modules.json
Sentry Logger [info]: Resolving modules from paths /Users/johndoe/Documents/repos/sentry-test-logger/android/app/src/main/assets/modules.json

Maybe the variable modulesPaths was supposed to have been used for Resolving modules from paths?

@krystofwoldrich
Copy link
Member

Hi, thank you for the message,
the Resolving modules from paths log should show the paths that are considered when collecting the modules. Typically this will be the node_modules dir of the project.

Exactly, modulesPaths should've been used.

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
Archived in project
Archived in project
2 participants