From 27d14dbbd733cdfe26a7baa252de51bec57db8f6 Mon Sep 17 00:00:00 2001 From: Shruthi Date: Thu, 18 Apr 2024 14:01:05 -0400 Subject: [PATCH] feat(spans): Add DLQ topic for buffered spans (#68571) Add DLQ to buffered-segments topic --- src/sentry/conf/server.py | 1 + src/sentry/conf/types/kafka_definition.py | 1 + src/sentry/consumers/__init__.py | 1 + 3 files changed, 3 insertions(+) diff --git a/src/sentry/conf/server.py b/src/sentry/conf/server.py index 2a582601dcddeb..430409f5e9cc7a 100644 --- a/src/sentry/conf/server.py +++ b/src/sentry/conf/server.py @@ -3484,6 +3484,7 @@ def build_cdc_postgres_init_db_volume(settings: Any) -> dict[str, dict[str, str] "snuba-spans": "default", "shared-resources-usage": "default", "buffered-segments": "default", + "buffered-segments-dlq": "default", } diff --git a/src/sentry/conf/types/kafka_definition.py b/src/sentry/conf/types/kafka_definition.py index 5fcaa94288c4e1..6f7ee8095c6fe8 100644 --- a/src/sentry/conf/types/kafka_definition.py +++ b/src/sentry/conf/types/kafka_definition.py @@ -48,6 +48,7 @@ class Topic(Enum): SHARED_RESOURCES_USAGE = "shared-resources-usage" SNUBA_SPANS = "snuba-spans" BUFFERED_SEGMENTS = "buffered-segments" + BUFFERED_SEGMENTS_DLQ = "buffered-segments-dlq" class ConsumerDefinition(TypedDict, total=False): diff --git a/src/sentry/consumers/__init__.py b/src/sentry/consumers/__init__.py index 9e265a5bcf5f52..debcd334438344 100644 --- a/src/sentry/consumers/__init__.py +++ b/src/sentry/consumers/__init__.py @@ -349,6 +349,7 @@ def ingest_events_options() -> list[click.Option]: "topic": Topic.BUFFERED_SEGMENTS, "strategy_factory": "sentry.spans.consumers.detect_performance_issues.factory.DetectPerformanceIssuesStrategyFactory", "click_options": multiprocessing_options(default_max_batch_size=100), + "dlq_topic": Topic.BUFFERED_SEGMENTS_DLQ, }, **settings.SENTRY_KAFKA_CONSUMERS, }