Skip to content

new RMS norm PR bricks stuff #190

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
nebulatgs opened this issue Mar 15, 2023 · 2 comments · Fixed by #191
Closed

new RMS norm PR bricks stuff #190

nebulatgs opened this issue Mar 15, 2023 · 2 comments · Fixed by #191

Comments

@nebulatgs
Copy link
Contributor

#187

No output from the model after this was merged.
@nebulatgs nebulatgs mentioned this issue Mar 15, 2023
Merged
@slaren
Copy link
Member

slaren commented Mar 15, 2023

Same issue here. For some reason the nth parameter seems to be zero and results in an infinite loop in ggml_compute_forward_rms_norm_f32.

@nebulatgs
Copy link
Contributor Author

Was a missing switch case in ggml.c

@Bearsaerker Bearsaerker mentioned this issue Mar 12, 2025
Open
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix RMS norm in GGML nebulatgs/llama.cpp
2 participants
@slaren @nebulatgs