New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Optimize by querying by ID #57

Open

bjwschaap opened this issue Jul 20, 2018 · 1 comment

Labels

area/daemon level/medium

bjwschaap commented Jul 20, 2018 •

edited

Loading

You don't need to fetch and loop through all services in the Swarm @

orbiter/autoscaler/autoscaler.go

Line 56 in e875318

for _, service := range services {

Instead you can add a filter, and fetch the required service directly. E.g.:

serviceFilter := filters.NewArgs()
serviceFilter.Add("id", serviceId)
services, err := dockerClient.ServiceList(ctx, types.ServiceListOptions{Filters: serviceFilter})

Also see: https://docs.docker.com/engine/reference/commandline/service_ls/#filtering

gianarb added area/daemon level/medium labels

Owner

gianarb commented Jul 20, 2018

This is a good catch @bjwschaap thanks!

# for free to join this conversation on GitHub. Already have an account? # to comment