Bug/41 #42
Closed
Bug/41 #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fntlnz
suggested changes
Aug 23, 2017
| service, _, err := p.dockerClient.ServiceInspectWithRaw(ctx, serviceId) | ||
| // Correct bug #41 using docker/docker v17.06.1-ce-rc4 | ||
| siopts := types.ServiceInspectOptions{} | ||
| siopts.InsertDefaults = true |
There was a problem hiding this comment.
I would avoid instantiating and then assigning siopts here.
It's just not needed anywhere else, it even fits 120 columns!
There was a problem hiding this comment.
Please add a comment like:
// Service inspect returns a service showing default values in empty fields
I had to actually execute the code to understand how the struct was filled, I don't want to do that too in the future :D
|
No problem, was afk for a while in the last days |
|
Sorry, I was happy to have it merged asap! ❤️ |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solve the issue #41
@fntlnz as you reported, i've updated using the workaround suggested moby/moby/issues/33989
This break vendoring at this time. Running again dep ensure will replace the docker/docker lib with version 17.5.0-ce-rc3