Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

The macron variant is no longer included in the LO crk spell-checker OXT package #5

Open
aarppe opened this issue Jul 11, 2020 · 7 comments
Labels
bug Something isn't working

Comments

@aarppe
Copy link
Contributor

aarppe commented Jul 11, 2020

The LibreOffice OXT extension for crk no longer includes the macron variant. While being the less used SRO variant in comparison to the SRO circumflex one, we do have some super-users (e.g. AEW) who'd prefer to use the macron variant.

EDIT: the macron variant is not included in: crk_LO-voikko-5.0.oxt, but can be installed with crk-x-macron_LO-voikko-5.0.oxt. It used to be that one got both circumflex and macron SRO variants with crk_LO-voikko-5.0.oxt, but that appears no longer to be the case. Is that intentional?

@aarppe aarppe added the bug Something isn't working label Jul 11, 2020
@flammie
Copy link
Contributor

flammie commented Jul 14, 2020

Hi, I was just debugging this and it seems that the alt orthographies and writing systems aren't included in a fresh build but will, probably unintentionally, go into the oxt if not cleaned between builds. I can add the alternates to the default build for now since it seems to work with LO-5, maybe we'll have more fine-grained control over it at some point?

@aarppe
Copy link
Contributor Author

aarppe commented Jul 14, 2020

At least until now I've found it practical that all the orthographical variants are included in the OXT for a particular language code, such as crk. And that used to be the case, and it seemed like a good default solution - of course, we can always decide to change, if we need to conserve space or for other reasons.

@snomos
Copy link
Member

snomos commented Aug 11, 2020

It is a bug that not all variants are included in the oxt - no need to have different oxt's for the different spellers for the same language. We'll fix this.

@aarppe
Copy link
Contributor Author

aarppe commented Aug 14, 2020

Ok, good. Out of interest, where are the contents (i.e. various variants) included in the crk OXT speller defined?

@snomos
Copy link
Member

snomos commented Aug 14, 2020

giella-core/am-shared/tools-spellcheckers-fstbased-desktop-hfst-dir-include.am
giella-core/am-shared/tools-spellcheckers-fstbased-desktop-hfst_alt_orth-dir-include.am
giella-core/am-shared/tools-spellcheckers-fstbased-desktop-hfst_alt_ws-dir-include.am
giella-core/am-shared/tools-spellcheckers-fstbased-desktop-hfst_area-dir-include.am
giella-core/am-shared/tools-spellcheckers-fstbased-desktop-hfst_prods_n_upload-dir-include.am

@flammie
Copy link
Contributor

flammie commented Aug 14, 2020

I think the default speller (e.g. crk_LO-voikko-5.0.oxt) should already include all orths and writing systems more consistently. The previous build had an odd race or so where first build (fresh or after make clean) had different files there than otherwise. This is after updating giella-core.

@snomos
Copy link
Member

snomos commented Oct 11, 2022

It is included, but there are other issues with the CRK spellers in LO. I'll keep this open for now.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants