Skip to content

injectAllReactorProjects overwrites non-git properties in reactor projects #108

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
tnaroska opened this issue May 5, 2014 · 2 comments · Fixed by #157
Closed

injectAllReactorProjects overwrites non-git properties in reactor projects #108

tnaroska opened this issue May 5, 2014 · 2 comments · Fixed by #157
Milestone

Comments

@tnaroska
Copy link

tnaroska commented May 5, 2014

The option injectAllReactorProjects should set the git-commit-id related properties in all reactor projects. Right now the code does not only propagate the git properties, but all properties set in the current project (i.e. in the pom.xml's element).
This can overwrite properties completely unrelated to git in other projects leading to unexpected behavior.

@Martin-Luft
Copy link

Today I started to use the maven-git-commit-id-plugin and I ran into the same issue :(
The only workaround is:
false

@kwin
Copy link

kwin commented Mar 9, 2015

This is a problem e.g. with the maven-scr-plugin and the maven-bundle-plugin, because they communicate via properties. If those properties are propagated across module boundaries this leads to all kind of errors.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants