Skip to content

Commit 981d90b

Browse files
committed
mingw: change core.fsyncObjectFiles = 1 by default
From the documentation of said setting: This boolean will enable fsync() when writing object files. This is a total waste of time and effort on a filesystem that orders data writes properly, but can be useful for filesystems that do not use journalling (traditional UNIX filesystems) or that only journal metadata and not file contents (OS X’s HFS+, or Linux ext3 with "data=writeback"). The most common file system on Windows (NTFS) does not guarantee that order, therefore a sudden loss of power (or any other event causing an unclean shutdown) would cause corrupt files (i.e. files filled with NULs). Therefore we need to change the default. Note that the documentation makes it sound as if this causes really bad performance. In reality, writing loose objects is something that is done only rarely, and only a handful of files at a time. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
1 parent 56f5feb commit 981d90b

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

compat/mingw.c

+2
Original file line numberDiff line numberDiff line change
@@ -3077,6 +3077,7 @@ int msc_startup(int argc, wchar_t **w_argv, wchar_t **w_env)
30773077
_CrtSetDbgFlag(_CRTDBG_ALLOC_MEM_DF | _CRTDBG_LEAK_CHECK_DF);
30783078
#endif
30793079

3080+
fsync_object_files = 1;
30803081
maybe_redirect_std_handles();
30813082

30823083
/* determine size of argv conversion buffer */
@@ -3143,6 +3144,7 @@ void mingw_startup(void)
31433144
wchar_t **wenv, **wargv;
31443145
_startupinfo si;
31453146

3147+
fsync_object_files = 1;
31463148
maybe_redirect_std_handles();
31473149

31483150
/* get wide char arguments and environment */

0 commit comments

Comments
 (0)