Skip to content

feat(iam, app): implements poh stamp provider #75

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 10 commits into from
May 18, 2022
Merged

feat(iam, app): implements poh stamp provider #75

merged 10 commits into from
May 18, 2022

Conversation

farque65
Copy link
Contributor

  • removes unused context functions from test context fixtures

[#3]

shavinac
shavinac approved these changes May 13, 2022
View reviewed changes
@shavinac shavinac self-requested a review May 18, 2022 13:51
farque65 and others added 8 commits May 18, 2022 10:24
@farque65 @david-focused
feat(iam, app): implements poh stamp provider
836fa9b 
- removes unused context functions from test context fixtures

[#3]
@shavinac @david-focused
test(app): remove unneeded stamp providers from context for individua…
33fb531 
…l stamp tests
@gdixon @david-focused
ci(github actions): creates production-app workflow to deploy product…
09ac68f 
…ion on workflow_dispatch
@gdixon @david-focused
ci(github actions): renames deploy production action
f0cf97e
@gdixon @david-focused
ci(github actions): fix for 'fatal: Not possible to fast-forward, abo…
bedfb87 
…rting.'
@gdixon @david-focused
fix(github actions): adds input to select the promoted branch/commit …
6c7f1e3 
…for production/staging
@farque65 @david-focused
feat(iam, app): implements poh stamp provider
2d1bd01 
- removes unused context functions from test context fixtures

[#3]
@shavinac @david-focused
test(app): remove unneeded stamp providers from context for individua…
8981536 
…l stamp tests
@david-focused
refactor(iam): remove unneccessary imports and comments from poh test
538fdf8 
[#3]
@david-focused
refactor(iam): remove RPC_URL environment variable from iam test step
f4407b5 
Previously, the IAM tests were relying on on-chain data and, therefore, needed the RPC_URL to run
tests.
 Since we don't rely on on-chain data anymore, we can remove the environment variable from
the test step.

 This also fixes the poh implementation to use the RPC_URL env variable instead of
being hard-coded to the mainnet variable. This matches the convention we are using elsewhere (ENS,
etc).

[#3]
@dhxdev dhxdev merged commit 0b5d5f9 into main May 18, 2022
@dhxdev dhxdev deleted the poh-stamp-wip branch May 18, 2022 15:17
@shavinac shavinac mentioned this pull request May 18, 2022
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@shavinac shavinac

@dhxdev dhxdev

@gdixon gdixon

@luke-focusedlabs luke-focusedlabs

Assignees

@dhxdev dhxdev

@farque65 farque65

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@farque65 @dhxdev @gdixon @shavinac @david-focused