Skip to content

Commit ffcf6d6

Browse files
tamasvajkredsun82Copilot
committed
Apply suggestions from code review
Co-authored-by: Paolo Tranquilli <redsun82@github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
1 parent d17d441 commit ffcf6d6

File tree

5 files changed

+462
-464
lines changed

5 files changed

+462
-464
lines changed

Diff for: ‎java/ql/integration-tests/java/query-suite/java-code-quality.qls.expected

+11-11
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
1-
/ql/java/ql/src/Language Abuse/TypeVariableHidesType.ql
2-
/ql/java/ql/src/Likely Bugs/Arithmetic/IntMultToLong.ql
3-
/ql/java/ql/src/Likely Bugs/Collections/WriteOnlyContainer.ql
4-
/ql/java/ql/src/Likely Bugs/Comparison/IncomparableEquals.ql
5-
/ql/java/ql/src/Likely Bugs/Comparison/InconsistentEqualsHashCode.ql
6-
/ql/java/ql/src/Likely Bugs/Comparison/MissingInstanceofInEquals.ql
7-
/ql/java/ql/src/Likely Bugs/Comparison/RefEqBoxed.ql
8-
/ql/java/ql/src/Likely Bugs/Likely Typos/ContradictoryTypeChecks.ql
9-
/ql/java/ql/src/Likely Bugs/Likely Typos/SuspiciousDateFormat.ql
10-
/ql/java/ql/src/Likely Bugs/Resource Leaks/CloseReader.ql
11-
/ql/java/ql/src/Likely Bugs/Resource Leaks/CloseWriter.ql
1+
ql/java/ql/src/Language Abuse/TypeVariableHidesType.ql
2+
ql/java/ql/src/Likely Bugs/Arithmetic/IntMultToLong.ql
3+
ql/java/ql/src/Likely Bugs/Collections/WriteOnlyContainer.ql
4+
ql/java/ql/src/Likely Bugs/Comparison/IncomparableEquals.ql
5+
ql/java/ql/src/Likely Bugs/Comparison/InconsistentEqualsHashCode.ql
6+
ql/java/ql/src/Likely Bugs/Comparison/MissingInstanceofInEquals.ql
7+
ql/java/ql/src/Likely Bugs/Comparison/RefEqBoxed.ql
8+
ql/java/ql/src/Likely Bugs/Likely Typos/ContradictoryTypeChecks.ql
9+
ql/java/ql/src/Likely Bugs/Likely Typos/SuspiciousDateFormat.ql
10+
ql/java/ql/src/Likely Bugs/Resource Leaks/CloseReader.ql
11+
ql/java/ql/src/Likely Bugs/Resource Leaks/CloseWriter.ql

Diff for: ‎java/ql/integration-tests/java/query-suite/java-code-scanning.qls.expected

+79-79
Original file line numberDiff line numberDiff line change
@@ -1,79 +1,79 @@
1-
/ql/java/ql/src/Diagnostics/ExtractionErrors.ql
2-
/ql/java/ql/src/Diagnostics/ExtractionWarnings.ql
3-
/ql/java/ql/src/Diagnostics/SuccessfullyExtractedFiles.ql
4-
/ql/java/ql/src/Likely Bugs/Arithmetic/InformationLoss.ql
5-
/ql/java/ql/src/Metrics/Summaries/LinesOfCode.ql
6-
/ql/java/ql/src/Metrics/Summaries/LinesOfCodeJava.ql
7-
/ql/java/ql/src/Metrics/Summaries/LinesOfCodeKotlin.ql
8-
/ql/java/ql/src/Security/CWE/CWE-020/OverlyLargeRange.ql
9-
/ql/java/ql/src/Security/CWE/CWE-022/TaintedPath.ql
10-
/ql/java/ql/src/Security/CWE/CWE-022/ZipSlip.ql
11-
/ql/java/ql/src/Security/CWE/CWE-023/PartialPathTraversalFromRemote.ql
12-
/ql/java/ql/src/Security/CWE/CWE-074/JndiInjection.ql
13-
/ql/java/ql/src/Security/CWE/CWE-074/XsltInjection.ql
14-
/ql/java/ql/src/Security/CWE/CWE-078/ExecTainted.ql
15-
/ql/java/ql/src/Security/CWE/CWE-078/ExecUnescaped.ql
16-
/ql/java/ql/src/Security/CWE/CWE-079/XSS.ql
17-
/ql/java/ql/src/Security/CWE/CWE-089/SqlTainted.ql
18-
/ql/java/ql/src/Security/CWE/CWE-090/LdapInjection.ql
19-
/ql/java/ql/src/Security/CWE/CWE-094/GroovyInjection.ql
20-
/ql/java/ql/src/Security/CWE/CWE-094/InsecureBeanValidation.ql
21-
/ql/java/ql/src/Security/CWE/CWE-094/JexlInjection.ql
22-
/ql/java/ql/src/Security/CWE/CWE-094/MvelInjection.ql
23-
/ql/java/ql/src/Security/CWE/CWE-094/SpelInjection.ql
24-
/ql/java/ql/src/Security/CWE/CWE-094/TemplateInjection.ql
25-
/ql/java/ql/src/Security/CWE/CWE-1104/MavenPomDependsOnBintray.ql
26-
/ql/java/ql/src/Security/CWE/CWE-113/NettyResponseSplitting.ql
27-
/ql/java/ql/src/Security/CWE/CWE-113/ResponseSplitting.ql
28-
/ql/java/ql/src/Security/CWE/CWE-1204/StaticInitializationVector.ql
29-
/ql/java/ql/src/Security/CWE/CWE-134/ExternallyControlledFormatString.ql
30-
/ql/java/ql/src/Security/CWE/CWE-200/SpringBootActuators.ql
31-
/ql/java/ql/src/Security/CWE/CWE-209/SensitiveDataExposureThroughErrorMessage.ql
32-
/ql/java/ql/src/Security/CWE/CWE-209/StackTraceExposure.ql
33-
/ql/java/ql/src/Security/CWE/CWE-266/IntentUriPermissionManipulation.ql
34-
/ql/java/ql/src/Security/CWE/CWE-287/AndroidInsecureLocalAuthentication.ql
35-
/ql/java/ql/src/Security/CWE/CWE-295/ImproperWebViewCertificateValidation.ql
36-
/ql/java/ql/src/Security/CWE/CWE-295/InsecureTrustManager.ql
37-
/ql/java/ql/src/Security/CWE/CWE-297/UnsafeHostnameVerification.ql
38-
/ql/java/ql/src/Security/CWE/CWE-312/CleartextStorageCookie.ql
39-
/ql/java/ql/src/Security/CWE/CWE-326/InsufficientKeySize.ql
40-
/ql/java/ql/src/Security/CWE/CWE-327/BrokenCryptoAlgorithm.ql
41-
/ql/java/ql/src/Security/CWE/CWE-330/InsecureRandomness.ql
42-
/ql/java/ql/src/Security/CWE/CWE-335/PredictableSeed.ql
43-
/ql/java/ql/src/Security/CWE/CWE-338/JHipsterGeneratedPRNG.ql
44-
/ql/java/ql/src/Security/CWE/CWE-347/MissingJWTSignatureCheck.ql
45-
/ql/java/ql/src/Security/CWE/CWE-352/SpringCSRFProtection.ql
46-
/ql/java/ql/src/Security/CWE/CWE-441/UnsafeContentUriResolution.ql
47-
/ql/java/ql/src/Security/CWE/CWE-470/FragmentInjection.ql
48-
/ql/java/ql/src/Security/CWE/CWE-470/FragmentInjectionInPreferenceActivity.ql
49-
/ql/java/ql/src/Security/CWE/CWE-489/DebuggableAttributeEnabled.ql
50-
/ql/java/ql/src/Security/CWE/CWE-489/WebviewDebuggingEnabled.ql
51-
/ql/java/ql/src/Security/CWE/CWE-502/UnsafeDeserialization.ql
52-
/ql/java/ql/src/Security/CWE/CWE-522/InsecureLdapAuth.ql
53-
/ql/java/ql/src/Security/CWE/CWE-552/UrlForward.ql
54-
/ql/java/ql/src/Security/CWE/CWE-601/UrlRedirect.ql
55-
/ql/java/ql/src/Security/CWE/CWE-611/XXE.ql
56-
/ql/java/ql/src/Security/CWE/CWE-614/InsecureCookie.ql
57-
/ql/java/ql/src/Security/CWE/CWE-643/XPathInjection.ql
58-
/ql/java/ql/src/Security/CWE/CWE-681/NumericCastTainted.ql
59-
/ql/java/ql/src/Security/CWE/CWE-730/PolynomialReDoS.ql
60-
/ql/java/ql/src/Security/CWE/CWE-730/ReDoS.ql
61-
/ql/java/ql/src/Security/CWE/CWE-730/RegexInjection.ql
62-
/ql/java/ql/src/Security/CWE/CWE-732/ReadingFromWorldWritableFile.ql
63-
/ql/java/ql/src/Security/CWE/CWE-780/RsaWithoutOaep.ql
64-
/ql/java/ql/src/Security/CWE/CWE-807/TaintedPermissionsCheck.ql
65-
/ql/java/ql/src/Security/CWE/CWE-829/InsecureDependencyResolution.ql
66-
/ql/java/ql/src/Security/CWE/CWE-917/OgnlInjection.ql
67-
/ql/java/ql/src/Security/CWE/CWE-918/RequestForgery.ql
68-
/ql/java/ql/src/Security/CWE/CWE-925/ImproperIntentVerification.ql
69-
/ql/java/ql/src/Security/CWE/CWE-926/ImplicitlyExportedAndroidComponent.ql
70-
/ql/java/ql/src/Security/CWE/CWE-927/ImplicitPendingIntents.ql
71-
/ql/java/ql/src/Security/CWE/CWE-940/AndroidIntentRedirection.ql
72-
/ql/java/ql/src/Telemetry/DatabaseQualityDiagnostics.ql
73-
/ql/java/ql/src/Telemetry/ExternalLibraryUsage.ql
74-
/ql/java/ql/src/Telemetry/ExtractorInformation.ql
75-
/ql/java/ql/src/Telemetry/SupportedExternalApis.ql
76-
/ql/java/ql/src/Telemetry/SupportedExternalSinks.ql
77-
/ql/java/ql/src/Telemetry/SupportedExternalSources.ql
78-
/ql/java/ql/src/Telemetry/SupportedExternalTaint.ql
79-
/ql/java/ql/src/Telemetry/UnsupportedExternalAPIs.ql
1+
ql/java/ql/src/Diagnostics/ExtractionErrors.ql
2+
ql/java/ql/src/Diagnostics/ExtractionWarnings.ql
3+
ql/java/ql/src/Diagnostics/SuccessfullyExtractedFiles.ql
4+
ql/java/ql/src/Likely Bugs/Arithmetic/InformationLoss.ql
5+
ql/java/ql/src/Metrics/Summaries/LinesOfCode.ql
6+
ql/java/ql/src/Metrics/Summaries/LinesOfCodeJava.ql
7+
ql/java/ql/src/Metrics/Summaries/LinesOfCodeKotlin.ql
8+
ql/java/ql/src/Security/CWE/CWE-020/OverlyLargeRange.ql
9+
ql/java/ql/src/Security/CWE/CWE-022/TaintedPath.ql
10+
ql/java/ql/src/Security/CWE/CWE-022/ZipSlip.ql
11+
ql/java/ql/src/Security/CWE/CWE-023/PartialPathTraversalFromRemote.ql
12+
ql/java/ql/src/Security/CWE/CWE-074/JndiInjection.ql
13+
ql/java/ql/src/Security/CWE/CWE-074/XsltInjection.ql
14+
ql/java/ql/src/Security/CWE/CWE-078/ExecTainted.ql
15+
ql/java/ql/src/Security/CWE/CWE-078/ExecUnescaped.ql
16+
ql/java/ql/src/Security/CWE/CWE-079/XSS.ql
17+
ql/java/ql/src/Security/CWE/CWE-089/SqlTainted.ql
18+
ql/java/ql/src/Security/CWE/CWE-090/LdapInjection.ql
19+
ql/java/ql/src/Security/CWE/CWE-094/GroovyInjection.ql
20+
ql/java/ql/src/Security/CWE/CWE-094/InsecureBeanValidation.ql
21+
ql/java/ql/src/Security/CWE/CWE-094/JexlInjection.ql
22+
ql/java/ql/src/Security/CWE/CWE-094/MvelInjection.ql
23+
ql/java/ql/src/Security/CWE/CWE-094/SpelInjection.ql
24+
ql/java/ql/src/Security/CWE/CWE-094/TemplateInjection.ql
25+
ql/java/ql/src/Security/CWE/CWE-1104/MavenPomDependsOnBintray.ql
26+
ql/java/ql/src/Security/CWE/CWE-113/NettyResponseSplitting.ql
27+
ql/java/ql/src/Security/CWE/CWE-113/ResponseSplitting.ql
28+
ql/java/ql/src/Security/CWE/CWE-1204/StaticInitializationVector.ql
29+
ql/java/ql/src/Security/CWE/CWE-134/ExternallyControlledFormatString.ql
30+
ql/java/ql/src/Security/CWE/CWE-200/SpringBootActuators.ql
31+
ql/java/ql/src/Security/CWE/CWE-209/SensitiveDataExposureThroughErrorMessage.ql
32+
ql/java/ql/src/Security/CWE/CWE-209/StackTraceExposure.ql
33+
ql/java/ql/src/Security/CWE/CWE-266/IntentUriPermissionManipulation.ql
34+
ql/java/ql/src/Security/CWE/CWE-287/AndroidInsecureLocalAuthentication.ql
35+
ql/java/ql/src/Security/CWE/CWE-295/ImproperWebViewCertificateValidation.ql
36+
ql/java/ql/src/Security/CWE/CWE-295/InsecureTrustManager.ql
37+
ql/java/ql/src/Security/CWE/CWE-297/UnsafeHostnameVerification.ql
38+
ql/java/ql/src/Security/CWE/CWE-312/CleartextStorageCookie.ql
39+
ql/java/ql/src/Security/CWE/CWE-326/InsufficientKeySize.ql
40+
ql/java/ql/src/Security/CWE/CWE-327/BrokenCryptoAlgorithm.ql
41+
ql/java/ql/src/Security/CWE/CWE-330/InsecureRandomness.ql
42+
ql/java/ql/src/Security/CWE/CWE-335/PredictableSeed.ql
43+
ql/java/ql/src/Security/CWE/CWE-338/JHipsterGeneratedPRNG.ql
44+
ql/java/ql/src/Security/CWE/CWE-347/MissingJWTSignatureCheck.ql
45+
ql/java/ql/src/Security/CWE/CWE-352/SpringCSRFProtection.ql
46+
ql/java/ql/src/Security/CWE/CWE-441/UnsafeContentUriResolution.ql
47+
ql/java/ql/src/Security/CWE/CWE-470/FragmentInjection.ql
48+
ql/java/ql/src/Security/CWE/CWE-470/FragmentInjectionInPreferenceActivity.ql
49+
ql/java/ql/src/Security/CWE/CWE-489/DebuggableAttributeEnabled.ql
50+
ql/java/ql/src/Security/CWE/CWE-489/WebviewDebuggingEnabled.ql
51+
ql/java/ql/src/Security/CWE/CWE-502/UnsafeDeserialization.ql
52+
ql/java/ql/src/Security/CWE/CWE-522/InsecureLdapAuth.ql
53+
ql/java/ql/src/Security/CWE/CWE-552/UrlForward.ql
54+
ql/java/ql/src/Security/CWE/CWE-601/UrlRedirect.ql
55+
ql/java/ql/src/Security/CWE/CWE-611/XXE.ql
56+
ql/java/ql/src/Security/CWE/CWE-614/InsecureCookie.ql
57+
ql/java/ql/src/Security/CWE/CWE-643/XPathInjection.ql
58+
ql/java/ql/src/Security/CWE/CWE-681/NumericCastTainted.ql
59+
ql/java/ql/src/Security/CWE/CWE-730/PolynomialReDoS.ql
60+
ql/java/ql/src/Security/CWE/CWE-730/ReDoS.ql
61+
ql/java/ql/src/Security/CWE/CWE-730/RegexInjection.ql
62+
ql/java/ql/src/Security/CWE/CWE-732/ReadingFromWorldWritableFile.ql
63+
ql/java/ql/src/Security/CWE/CWE-780/RsaWithoutOaep.ql
64+
ql/java/ql/src/Security/CWE/CWE-807/TaintedPermissionsCheck.ql
65+
ql/java/ql/src/Security/CWE/CWE-829/InsecureDependencyResolution.ql
66+
ql/java/ql/src/Security/CWE/CWE-917/OgnlInjection.ql
67+
ql/java/ql/src/Security/CWE/CWE-918/RequestForgery.ql
68+
ql/java/ql/src/Security/CWE/CWE-925/ImproperIntentVerification.ql
69+
ql/java/ql/src/Security/CWE/CWE-926/ImplicitlyExportedAndroidComponent.ql
70+
ql/java/ql/src/Security/CWE/CWE-927/ImplicitPendingIntents.ql
71+
ql/java/ql/src/Security/CWE/CWE-940/AndroidIntentRedirection.ql
72+
ql/java/ql/src/Telemetry/DatabaseQualityDiagnostics.ql
73+
ql/java/ql/src/Telemetry/ExternalLibraryUsage.ql
74+
ql/java/ql/src/Telemetry/ExtractorInformation.ql
75+
ql/java/ql/src/Telemetry/SupportedExternalApis.ql
76+
ql/java/ql/src/Telemetry/SupportedExternalSinks.ql
77+
ql/java/ql/src/Telemetry/SupportedExternalSources.ql
78+
ql/java/ql/src/Telemetry/SupportedExternalTaint.ql
79+
ql/java/ql/src/Telemetry/UnsupportedExternalAPIs.ql

0 commit comments

Comments
 (0)