Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

On PR when no change is done to a ruleset it complains with an error and silently fails and does not process other results #744

Open
wernerb opened this issue Jan 22, 2025 · 0 comments · May be fixed by #747
Labels
bug Something isn't working

Comments

@wernerb
Copy link

wernerb commented Jan 22, 2025

Problem Description

When no change is necessary for a ruleset for settings.yml (org level) it errors on that it cannot read properties of undefined. It then ignores and does not process subrepo/repo level changes.

What is actually happening

What is the expected behavior

No error, it continues processing other changes.

Error output, if available

{"level":20,"time":1737560351603,"pid":24,"hostname":"safe-settings-749754f886-vsvs2","name":"probot","name":"probot","name":"event","id":"0419c260-d8d7-11ef-9598-94abba56187a","msg":"There are no changes for Rulesets for repo [object Object]. Skipping changes"}
{"level":50,"time":1737560351603,"pid":24,"hostname":"safe-settings-749754f886-vsvs2","name":"probot","name":"probot","name":"event","id":"0419c260-d8d7-11ef-9598-94abba56187a","msg":"Cannot read properties of undefined (reading 'flat')"}

Context

Are you using the hosted instance of probot/settings or running your own?

If running your own instance, are you using it with github.com or GitHub Enterprise?

Version of probot/settings

Version of GitHub Enterprise

@wernerb wernerb added the bug Something isn't working label Jan 22, 2025
@PendaGTP PendaGTP linked a pull request Jan 22, 2025 that will close this issue
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant