Skip to content

Adding python 3.9, release prior to dropping 3.4. #1132

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
Yobmod opened this issue Feb 24, 2021 · 2 comments · Fixed by #1184
Closed

Adding python 3.9, release prior to dropping 3.4. #1132

Yobmod opened this issue Feb 24, 2021 · 2 comments · Fixed by #1184

Comments

@Yobmod
Copy link
Contributor

Yobmod commented Feb 24, 2021

#1131

Hi,
When running the tests after dropping 3.4, I also tested against 3.9 on Linux. All tests passed, so I was thinking to add simply add 3.9. But will probably want final 3.4 release cutting before either are merged?

Dropping 3.4 allows the use of function type hints and async/await coroutines.

Note: According to https://pypistats.org/packages/gitpython python 3.4 downloads are at 0.04% and 3.5 is still at 3.38%

@Byron
Copy link
Member

Byron commented Feb 25, 2021

Thanks for the great release planning to maximize usability! I wonder if people running 3.9 wouldn't be able to install GitPython just because python 3.9 isn't listed?

If you see issues there, I would be waiting for a PR who adds python 3.9 support before #1131 is merged.

@Yobmod
Copy link
Contributor Author

Yobmod commented Feb 26, 2021

#1184
I've added 3.9 support. All checks passed.

I'll resubmit the drop 3.4 PR once this is accepted, as they touch all the same files.

# for free to join this conversation on GitHub. Already have an account? # to comment
Development

Successfully merging a pull request may close this issue.

2 participants