From ed69ee7f3282b304e0303464cb5dbc072d39c363 Mon Sep 17 00:00:00 2001 From: Marcel van Remmerden Date: Fri, 28 Jun 2024 18:20:45 +0000 Subject: [PATCH] Remove unnecessary try catch --- src/__tests__/initFirebaseClientSDK.test.ts | 15 +++++++++------ src/useFirebaseUser.ts | 17 +++++++---------- 2 files changed, 16 insertions(+), 16 deletions(-) diff --git a/src/__tests__/initFirebaseClientSDK.test.ts b/src/__tests__/initFirebaseClientSDK.test.ts index cfae6104..2533e443 100644 --- a/src/__tests__/initFirebaseClientSDK.test.ts +++ b/src/__tests__/initFirebaseClientSDK.test.ts @@ -30,12 +30,15 @@ describe('initFirebaseClientSDK', () => { expect.assertions(1) const initFirebaseClientSDK = require('src/initFirebaseClientSDK').default initFirebaseClientSDK() - expect(mockInitializeApp).toHaveBeenCalledWith({ - apiKey: 'fakeAPIKey123', - authDomain: 'my-example-app.firebaseapp.com', - databaseURL: 'https://my-example-app.firebaseio.com', - projectId: 'my-example-app-id', - }) + expect(mockInitializeApp).toHaveBeenCalledWith( + { + apiKey: 'fakeAPIKey123', + authDomain: 'my-example-app.firebaseapp.com', + databaseURL: 'https://my-example-app.firebaseio.com', + projectId: 'my-example-app-id', + }, + undefined + ) }) it('does not call firebase.initializeApp if Firebase already has an initialized app', () => { diff --git a/src/useFirebaseUser.ts b/src/useFirebaseUser.ts index 0a74f506..93f9c02b 100644 --- a/src/useFirebaseUser.ts +++ b/src/useFirebaseUser.ts @@ -176,16 +176,13 @@ const useFirebaseUser = () => { } // https://firebase.google.com/docs/reference/js/firebase.auth.Auth#onidtokenchanged - try { - const { firebaseClientAppName } = getConfig() - const app = getApp(firebaseClientAppName) - const unsubscribe = onIdTokenChanged(getAuth(app), onIdTokenChange) - return () => { - unsubscribe() - isCancelled = true - } - } catch (error) { - throw error + + const { firebaseClientAppName } = getConfig() + const app = getApp(firebaseClientAppName) + const unsubscribe = onIdTokenChanged(getAuth(app), onIdTokenChange) + return () => { + unsubscribe() + isCancelled = true } }, [])