feat(input): add warning props to text, textarea, and number #584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for sefirot-story ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for sefirot-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
brc-dd
approved these changes
Feb 21, 2025
brc-dd
reviewed
Feb 21, 2025
There was a problem hiding this comment.
<HstCheckbox
title="error"
v-model="state.error"
/>this is not used, maybe we can swap it with warning
There was a problem hiding this comment.
other stuff is also not used -- align, disabled, separator?
There was a problem hiding this comment.
Hah... yeah w might wanna organize these... 🫠
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not proud of my self but added
:warningprops to text, textarea, and number input components. Also refactored those to use base props exported from base input (there were just so many input to do it in one shot 😅 )