Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Outdated nullified attributes #157

Open
skalee opened this issue Mar 17, 2021 · 1 comment
Open

Outdated nullified attributes #157

skalee opened this issue Mar 17, 2021 · 1 comment

Comments

@skalee
Copy link
Contributor

skalee commented Mar 17, 2021

I'm going to delete these. They're probably some TC211 leftovers, not very useful here nor in any future project.

# @todo: Unsorted Attributes
#
# We need to revisit this attributes and also update
# the correct mapping with the existing attributes.
#
abbrev: nil,
alt: nil,
country_code: nil,
review_indicator: nil,
authoritative_source_similarity: nil,
lineage_source: nil,
review_status: nil,
review_type: nil,
review_decision_notes: nil,

They are further "used" in https://github.com/glossarist/iev-data/blob/master/lib/iev/termbase/term.rb.

@ronaldtse WDYT?

@ronaldtse
Copy link
Member

Sure, let's delete them. We do have to keep in mind that a future import of IEV may include entries where the "status" is not "Standard" (i.e. drafts).

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants