Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Execute run with pretend in template testing #252

Closed
vyasr opened this issue Feb 21, 2020 · 2 comments · Fixed by #279
Closed

Execute run with pretend in template testing #252

vyasr opened this issue Feb 21, 2020 · 2 comments · Fixed by #279
Assignees
Labels
enhancement New feature or request groups

Comments

@vyasr
Copy link
Contributor

vyasr commented Feb 21, 2020

With the addition of groups, template testing is no longer as useful because all the scripts just use python project.py run..., which prevents us from verifying that the mpirun, OMP_NUM_THREADS and other command prefixes are correctly handled. We should add a project.run(..., pretend=True) called to the template test output so that we can test this behavior in the future.

@kidrahahjo
Copy link
Collaborator

@vyasr I'd like to work on this issue. Can you please assign me this?

@vyasr
Copy link
Contributor Author

vyasr commented Feb 26, 2020

Hi Hardik, I'm glad you're interested in working on this issue. Unfortunately, a significant component of this issue will be manually verifying the output of our job submission process. I'm triaging a lot of issues right now and will let you know as soon as I find one that would be appropriate for you to tackle.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request groups
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants