Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Rename FN_MANIFEST #478

Closed
bdice opened this issue Jan 24, 2021 · 6 comments
Closed

Rename FN_MANIFEST #478

bdice opened this issue Jan 24, 2021 · 6 comments
Labels
pinned Instructs stale bot to ignore this issue. refactor Code refactoring
Milestone

Comments

@bdice
Copy link
Member

bdice commented Jan 24, 2021

Suggesting this change for signac 2.0:

  • Job.FN_MANIFEST and similar properties of Job/Project should be private.
  • "Manifest" should be changed to "state point" universally in variable names and docstrings.
  • e.g. FN_MANIFEST should be _FN_STATE_POINT.
@bdice bdice added the refactor Code refactoring label Jan 24, 2021
@bdice bdice added this to the v2.0.0 milestone Jan 24, 2021
@stale
Copy link

stale bot commented Mar 31, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Mar 31, 2021
@vyasr
Copy link
Contributor

vyasr commented Mar 31, 2021

Still relevant, will be addressed as part of #527.

@stale stale bot removed the stale label Mar 31, 2021
@stale
Copy link

stale bot commented Jun 2, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jun 2, 2021
@csadorf csadorf added pinned Instructs stale bot to ignore this issue. and removed stale labels Jun 3, 2021
@vyasr
Copy link
Contributor

vyasr commented May 2, 2022

This issue was addressed by #610. Unless there's a reason to revisit the visibility of the attributes, I think we can close this. @bdice what do you think?

@bdice
Copy link
Member Author

bdice commented May 9, 2022

I'd still like to make these attributes private. I can handle creating a PR.

@bdice
Copy link
Member Author

bdice commented May 10, 2022

I thought about this some more. Maybe these should remain public? I don't have strong feelings so maybe this is better to close and leave as-is.

@bdice bdice closed this as completed May 10, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
pinned Instructs stale bot to ignore this issue. refactor Code refactoring
Projects
None yet
Development

No branches or pull requests

3 participants