Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Font editor not added to Inspector for custom controls #175

Closed
gluon-bot opened this issue Apr 12, 2018 · 1 comment
Closed

Font editor not added to Inspector for custom controls #175

gluon-bot opened this issue Apr 12, 2018 · 1 comment
Labels
bug Something isn't working major

Comments

@gluon-bot
Copy link

Originally reported by: Jose Pereda (Bitbucket: JPereda, GitHub: JPereda)


Custom control properties are scanned and the proper editor for each of them is added to the Inspector panel's custom tab.

In case a of a property of type Font, this doesn't happen, because the Font class is not taken into account by MetadataInstrospector::makePropertyMetadata.

This will solve the issue:

#!java

          } else if (propertyType == javafx.scene.text.Font.class) {
                result = new FontPropertyMetadata(
                        name,
                        readWrite,
                        (Font) getDefaultValue(sample, propertyDescriptor.getReadMethod(), null),
                        inspectorPath);
         }...   

@gluon-bot gluon-bot added major bug Something isn't working labels May 9, 2018
@jperedadnr
Copy link
Collaborator

jperedadnr commented May 28, 2018

Solved with PR #67

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working major
Projects
None yet
Development

No branches or pull requests

2 participants