Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Maven Resolver can't be excluded when importing Scene Builder Kit #777

Closed
jperedadnr opened this issue Oct 25, 2024 · 0 comments · Fixed by #779
Closed

Maven Resolver can't be excluded when importing Scene Builder Kit #777

jperedadnr opened this issue Oct 25, 2024 · 0 comments · Fixed by #779
Assignees
Labels
bug Something isn't working

Comments

@jperedadnr
Copy link
Collaborator

Currently, Maven Resolver (and related modules) are required in the module descriptor of Scene Builder Kit.

If a third party that embeds SB Kit doesn't need this feature, it shouldn't need to add all the related dependencies.

This is typically done with:

<dependency>
            <groupId>com.gluonhq.scenebuilder</groupId>
            <artifactId>kit</artifactId>
            <version>24.0.0-SNAPSHOT</version>
            <exclusions>
                <exclusion>
                    <groupId>org.apache.maven.resolver</groupId>
                    <artifactId>*</artifactId>
                </exclusion>
            </exclusions>
        </dependency>

however, since the module-info requires Maven Resolver, there is an error:

Error occurred during initialization of boot layer
java.lang.module.FindException: Module org.apache.maven.resolver.supplier not found, required by com.gluonhq.scenebuilder.kit

This can be fixed

Expected Behavior

Maven Resolver modules are optional, and Maven Resolver dependencies can be excluded

Current Behavior

Maven Resolver modules are mandatory, and Maven Resolver dependencies can't be excluded

Steps to Reproduce

Your Environment

Screenshots

@jperedadnr jperedadnr added the bug Something isn't working label Oct 25, 2024
@jperedadnr jperedadnr self-assigned this Oct 25, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant