-
-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Seems like 2.1.x version conflicts with the «Night Mode» addon. #9
Comments
Thanks for letting me know, July. It seems @krassowski has recently released a completely overhauled version of the night mode add-on for 2.1. Does the issue still persist with that? |
@JulyMorning what is the exact problem you experience? @glutanimate we both use I am not sure why, but when I tried it in 2.1 Beta 16 both add-ons worked well. I did not use the heatmap before (so I may not know about certain, possibly lacking features) but both deck browser and overview screens have their heatmaps and are styled nicely. PS. A minor issue is some glittering when going back from overview to deck browser. Let me know if you spot what's causing it. Cheers! |
@krassowski Thanks for chiming in and investigating this! Yep, the add-on replaces the overview body altogether. As far as I remember this was necessary to get the layout right, but I will see if I can find a different way to handle this when I find the time. Not sure why the add-ons would work in some instances, but not in others. Perhaps a race condition where the result varies depending on which add-on is loaded first by Anki? The module loading order seems to depend on the path of Anki's add-on directory which is user-specific of course. |
Could you share steps to test HeatMap with Anki 2.1. |
@rptr87 @salthepal @HongKTruong The repo is currently in somewhat of a transitional state, but I will let you guys know once the beta for the v0.7.0 release is ready (which will bring 2.1 support, among other things). At that point I will also try to look into potential compatibility issues with Night Mode again. |
Hey everyone, I'm happy to say that the first beta release of v0.7.0 is finally here! Among other things it comes with full night mode support (including a series of themes specifically crafted for night mode). If you could give it a try and report back about your experience I'd really appreciate that. Please make sure to upgrade Night Mode to the latest release if you do, as it packs some changes that Review Heatmap depends on. Major shout-out to @krassowski for shouldering the work on Night Mode's end! |
Also: I'd love to hear you guys' thoughts on the night themes. For most of them I inverted the color assignment compared to their day counterparts. I feel like this works well for some themes (e.g. magenta, flame, ice), but as well for others (e.g. olive, lime). But I'm not sure in what direction to take the night versions of the latter. Any kind of feedback would be much appreciated! |
Hi, I don't think color should change at Night Mode. It makes me confused. |
Personally I'm a fan of the color inversion, particularly for the flame theme. |
I'm not able to see the changes right now, but, please, make any colour conversion optional. |
Not sure what the current status for this is. I do have the most recent version of both, and all works well without any observed issues. I would greatly appreciate the ability to turn off the color inversion, though, as it does become confusing. Thanks for a great add-on |
Anki now has built-in night mode and the night mode addon has been archived. This should probably be closed. |
@NilsIrl 👍 |
I don't actually know, if it's possible to fix it, but both of these addons are great.
— https://github.com/krassowski/Anki-Night-Mode
2.0.x was ok. Thanks.
The text was updated successfully, but these errors were encountered: