Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Seems like 2.1.x version conflicts with the «Night Mode» addon. #9

Closed
JulyMorning opened this issue Aug 26, 2017 · 14 comments
Closed
Assignees
Labels
add-on conflict Conflict with another add-on anki21 Issue observed on Anki 2.1.x
Milestone

Comments

@JulyMorning
Copy link

I don't actually know, if it's possible to fix it, but both of these addons are great.

https://github.com/krassowski/Anki-Night-Mode

2.0.x was ok. Thanks.

@glutanimate
Copy link
Owner

Thanks for letting me know, July. It seems @krassowski has recently released a completely overhauled version of the night mode add-on for 2.1. Does the issue still persist with that?

@krassowski
Copy link

@JulyMorning what is the exact problem you experience?

@glutanimate we both use Overview._body (stylers.py#L230 in Night Mode). I just append styles to the existing body while your addon (If I understand correctly) attempts to replace it with a hardcoded value altogether (see main.py#L239).

I am not sure why, but when I tried it in 2.1 Beta 16 both add-ons worked well. I did not use the heatmap before (so I may not know about certain, possibly lacking features) but both deck browser and overview screens have their heatmaps and are styled nicely.

PS. A minor issue is some glittering when going back from overview to deck browser. Let me know if you spot what's causing it.

Cheers!

@glutanimate
Copy link
Owner

@krassowski Thanks for chiming in and investigating this! Yep, the add-on replaces the overview body altogether. As far as I remember this was necessary to get the layout right, but I will see if I can find a different way to handle this when I find the time.

Not sure why the add-ons would work in some instances, but not in others. Perhaps a race condition where the result varies depending on which add-on is loaded first by Anki? The module loading order seems to depend on the path of Anki's add-on directory which is user-specific of course.

@krassowski
Copy link

Concurrency may be the problem here.

What I found out recently is that when review-heatmap is enabled it effectively prevents night-mode to style counts on the overview screen:

screenshot from 2017-10-14 12-23-20
screenshot from 2017-10-14 12-22-49

That's not a big issue though.

@rptrcode
Copy link

@JulyMorning @krassowski

Could you share steps to test HeatMap with Anki 2.1.
I placed py script into Anki21 addon folders but it does not seem to work.

@glutanimate glutanimate added this to the v0.7.0 milestone Sep 17, 2018
@glutanimate glutanimate self-assigned this Sep 17, 2018
@glutanimate
Copy link
Owner

@rptr87 @salthepal @HongKTruong The repo is currently in somewhat of a transitional state, but I will let you guys know once the beta for the v0.7.0 release is ready (which will bring 2.1 support, among other things). At that point I will also try to look into potential compatibility issues with Night Mode again.

@glutanimate
Copy link
Owner

Hey everyone,

I'm happy to say that the first beta release of v0.7.0 is finally here!

Among other things it comes with full night mode support (including a series of themes specifically crafted for night mode). If you could give it a try and report back about your experience I'd really appreciate that. Please make sure to upgrade Night Mode to the latest release if you do, as it packs some changes that Review Heatmap depends on.

Major shout-out to @krassowski for shouldering the work on Night Mode's end!

@glutanimate
Copy link
Owner

Also: I'd love to hear you guys' thoughts on the night themes. For most of them I inverted the color assignment compared to their day counterparts. I feel like this works well for some themes (e.g. magenta, flame, ice), but as well for others (e.g. olive, lime). But I'm not sure in what direction to take the night versions of the latter. Any kind of feedback would be much appreciated!

@corwin1949
Copy link

Also: I'd love to hear you guys' thoughts on the night themes. For most of them I inverted the color assignment compared to their day counterparts. I feel like this works well for some themes (e.g. magenta, flame, ice), but as well for others (e.g. olive, lime). But I'm not sure in what direction to take the night versions of the latter. Any kind of feedback would be much appreciated!

Hi, I don't think color should change at Night Mode. It makes me confused.
and thanks for you work.

@salthepal
Copy link

salthepal commented Nov 15, 2018

Personally I'm a fan of the color inversion, particularly for the flame theme.

@JulyMorning
Copy link
Author

I'm not able to see the changes right now, but, please, make any colour conversion optional.

@glutanimate glutanimate added add-on conflict Conflict with another add-on anki21 Issue observed on Anki 2.1.x labels Apr 18, 2019
@MS3509
Copy link

MS3509 commented Apr 27, 2019

Not sure what the current status for this is. I do have the most recent version of both, and all works well without any observed issues. I would greatly appreciate the ability to turn off the color inversion, though, as it does become confusing.

Thanks for a great add-on

@NilsIrl
Copy link

NilsIrl commented Apr 9, 2021

Anki now has built-in night mode and the night mode addon has been archived. This should probably be closed.

@glutanimate
Copy link
Owner

@NilsIrl 👍

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
add-on conflict Conflict with another add-on anki21 Issue observed on Anki 2.1.x
Projects
None yet
Development

No branches or pull requests

8 participants