Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Benchmark testing can not work because of thread.lock failed. #56

Open
Hangdong-Zhang opened this issue Oct 26, 2017 · 9 comments
Open

Comments

@Hangdong-Zhang
Copy link

When I do any benchmark testing, it always error because of thread.lock failed.
The error info is:
the error info of thread lock failed

The version info:
gnocchiclient (2.7.0)
cliff (2.2.0)

@jd
Copy link
Member

jd commented Oct 27, 2017

Try Python 3?

@chungg
Copy link
Member

chungg commented Oct 27, 2017

i have python 2.7.10 and it works. i believe it was broken in one of the python2 builds

@Hangdong-Zhang
Copy link
Author

It is the same error on python 2.7.5, 2.7.12, and 3.5. I guess it may not related with the python version.
@chungg could you please tell the the version of other packages on you site. such as: gnocchi, gnocchiclient, cliff, and any other related with multiprocess you known. Thanks a lot.

@chungg
Copy link
Member

chungg commented Oct 30, 2017

cliff==2.8.0
gnocchiclient==3.3.1
futures==3.1.1
futurist==1.3.0

@Hangdong-Zhang
Copy link
Author

It still can not work, the same error on every version of python and gnocchiclient.
Could you please recheck it on any other Linux with gnocchiclient.

@chungg
Copy link
Member

chungg commented Oct 31, 2017

maybe just switch ProcessPoolExecutor to ThreadPoolExecutor... i think it's better anyways

class BenchmarkPool(futurist.ProcessPoolExecutor):

@Hangdong-Zhang
Copy link
Author

@chungg pretty thanks. It works.
But it seems lack of some data in result, such as: create runtime, create speed.
_20171101153530

@chungg
Copy link
Member

chungg commented Nov 1, 2017

@Hangdong-Zhang
Copy link
Author

Oh, great! Now the benchmark testing works well. Thank you very much! @chungg

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Development

No branches or pull requests

3 participants