Skip to content

fix(#1966): go2Gno loses type info #2016

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 11 commits into from
May 23, 2024
Merged

fix(#1966): go2Gno loses type info #2016

merged 11 commits into from
May 23, 2024

Conversation

omarsy
Copy link
Member

@omarsy omarsy commented May 1, 2024

fixes #1966

Contributors' checklist...
  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs
  • Provided any useful hints for running manual tests
  • Added new benchmarks to generated graphs, if any. More info here.

@github-actions github-actions bot added the 📦 🤖 gnovm Issues or PRs gnovm related label May 1, 2024
Copy link

codecov bot commented May 1, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 48.85%. Comparing base (ccc6d5b) to head (3c7b5ed).

Files Patch % Lines
gnovm/pkg/gnolang/preprocess.go 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2016      +/-   ##
==========================================
- Coverage   49.04%   48.85%   -0.20%     
==========================================
  Files         576      579       +3     
  Lines       77556    78038     +482     
==========================================
+ Hits        38035    38122      +87     
- Misses      36439    36830     +391     
- Partials     3082     3086       +4     
Flag Coverage Δ
gnovm 42.14% <85.71%> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@omarsy omarsy marked this pull request as ready for review May 5, 2024 17:18
@omarsy omarsy requested review from jaekwon, moul, piux2 and deelawn as code owners May 5, 2024 17:18
@thehowl thehowl requested a review from ltzmaxwell May 7, 2024 18:37
@thehowl
Copy link
Member

thehowl commented May 7, 2024

cc @ltzmaxwell

@ltzmaxwell
Copy link
Contributor

thank you for your work, start looking.

@omarsy omarsy requested review from thehowl and mvertes as code owners May 11, 2024 16:50
@ltzmaxwell
Copy link
Contributor

cc @deelawn for a second look.

Copy link
Member

@thehowl thehowl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix up the unit tests; after that we're good to go.

@thehowl thehowl merged commit f3ddc44 into gnolang:master May 23, 2024
134 of 136 checks passed
@omarsy omarsy deleted the fix/1966 branch May 23, 2024 14:13
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
📦 🤖 gnovm Issues or PRs gnovm related
Projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

go2Gno loses type info
5 participants