Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

test(cmd/gnoland): add test to ensure to not import tests/stdlibs #3589

Merged
merged 6 commits into from
Feb 6, 2025
Merged

test(cmd/gnoland): add test to ensure to not import tests/stdlibs #3589

merged 6 commits into from
Feb 6, 2025

Conversation

thehowl
Copy link
Member

@thehowl thehowl commented Jan 23, 2025

Fixes #3585

@thehowl thehowl self-assigned this Jan 23, 2025
@github-actions github-actions bot added the 📦 ⛰️ gno.land Issues or PRs gno.land package related label Jan 23, 2025
@Gno2D2
Copy link
Collaborator

Gno2D2 commented Jan 23, 2025 •
edited
Loading

🛠 PR Checks Summary

All Automated Checks passed. ✅

Manual Checks (for Reviewers):
  • IGNORE the bot requirements for this PR (force green CI check)
Read More

🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers.

✅ Automated Checks (for Contributors):

🟢 Maintainers must be able to edit this pull request (more info)

☑️ Contributor Actions:
  1. Fix any issues flagged by automated checks.
  2. Follow the Contributor Checklist to ensure your PR is ready for review.
    • Add new tests, or document why they are unnecessary.
    • Provide clear examples/screenshots, if necessary.
    • Update documentation, if required.
    • Ensure no breaking changes, or include BREAKING CHANGE notes.
    • Link related issues/PRs, where applicable.
☑️ Reviewer Actions:
  1. Complete manual checks for the PR, including the guidelines and additional checks if applicable.
📚 Resources:
Debug
Automated Checks
Maintainers must be able to edit this pull request (more info)

If

🟢 Condition met
└── 🟢 And
    ├── 🟢 The base branch matches this pattern: ^master$
    └── 🟢 The pull request was created from a fork (head branch repo: thehowl/gno)

Then

🟢 Requirement satisfied
└── 🟢 Maintainer can modify this pull request
Manual Checks
**IGNORE** the bot requirements for this PR (force green CI check)

If

🟢 Condition met
└── 🟢 On every pull request

Can be checked by

  • Any user with comment edit permission

@codecov Codecov
Copy link

codecov bot commented Jan 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@thehowl thehowl merged commit 37ab807 into gnolang:master Feb 6, 2025
55 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@kristovatlas kristovatlas kristovatlas approved these changes

@zivkovicmilos zivkovicmilos Awaiting requested review from zivkovicmilos

Assignees

@thehowl thehowl

Labels
📦 ⛰️ gno.land Issues or PRs gno.land package related
Projects
🧙‍♂️gno.land core team
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add test verifying go list of dependencies on cmd/gnoland doesn't contain tests/stdlibs
3 participants
@thehowl @Gno2D2 @kristovatlas