Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Split terminals do not keep their sizes ratio when resizing the window #613

Closed
f2404 opened this issue Dec 13, 2016 · 4 comments
Closed
Labels

Comments

@f2404
Copy link
Contributor

f2404 commented Dec 13, 2016

Open the terminal and split it vertically - both terminals will have the same width. Then resize the window to increase its width - the first terminal will become wider than the second one.
The same happens when splitting horizontally and increasing window height.

@f2404 f2404 changed the title Split terminal sessions do not keep their sizes ratio when resizing Split terminals do not keep their sizes ratio when resizing the window Dec 13, 2016
@gnunn1
Copy link
Owner

gnunn1 commented Dec 13, 2016

Hmm, interesting as I haven't noticed that before. I'm not sure there is much I can do about it, it's really up to GTK to manage the layouts but I'll have a look.

@gnunn1 gnunn1 added the bug label Dec 13, 2016
@gnunn1 gnunn1 closed this as completed in 926f57e Dec 14, 2016
@gnunn1
Copy link
Owner

gnunn1 commented Dec 14, 2016

I've introduced a subclass of Paned that explictly maintains the ratio. In my testing this seems to work well, hopefully it hasn't introduced any new regressions.

@gnunn1
Copy link
Owner

gnunn1 commented Dec 14, 2016

This breaks loading sessions from files, I made need to defer a fix for this until after 1.4.0

@gnunn1 gnunn1 reopened this Dec 14, 2016
@gnunn1 gnunn1 closed this as completed in c74463e Dec 15, 2016
@gnunn1
Copy link
Owner

gnunn1 commented Dec 15, 2016

I think this should be good to go now, however note that if you load an older session file terminix will use the old behavior and not automatically set the paned position based on the ratio. If you re-save the file, you will get the new behavior.

GTK really needs a Paned widget that can handle more then a single split. :)

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants