prevent checkbox caching via autocomplete=off

Author: silverwind

templates/repo/issue/list.tmpl

@@ -29,7 +29,7 @@
 		<div id="issue-filters" class="ui stackable grid">
 			<div class="six wide column">
 				{{if $.CanWriteIssuesOrPulls}}
-					<input type="checkbox" class="issue-checkbox-all gt-vm gt-mr-4" title="{{.locale.Tr "repo.issues.action_check_all"}}">
+					<input type="checkbox" autocomplete="off" class="issue-checkbox-all gt-vm gt-mr-4" title="{{.locale.Tr "repo.issues.action_check_all"}}">
 				{{end}}
 				{{template "repo/issue/openclose" .}}
 			</div>

templates/shared/issuelist.tmpl

@@ -4,7 +4,7 @@
 		<li class="item gt-df gt-py-3">
 			<div class="issue-item-left gt-df gt-items-start">
 				{{if $.CanWriteIssuesOrPulls}}
-					<input type="checkbox" class="issue-checkbox gt-mt-2 gt-mr-4" data-issue-id={{.ID}} title="{{$.locale.Tr "repo.issues.action_check"}} «{{.Title}}»">
+					<input type="checkbox" autocomplete="off" class="issue-checkbox gt-mt-2 gt-mr-4" data-issue-id={{.ID}} title="{{$.locale.Tr "repo.issues.action_check"}} «{{.Title}}»">
 				{{end}}
 				<div class="issue-item-icon">
 					{{if .IsPull}}

web_src/js/features/common-issue.js

@@ -53,12 +53,6 @@ export function initCommonIssue() {
       issueIDs,
       elementId
     ).then(() => {
-      // NOTICE: This reset of checkbox state targets Firefox caching behaviour, as the
-      // checkboxes stay checked after reload
-      if (action === 'close' || action === 'open') {
-        // uncheck all checkboxes
-        $('.issue-checkbox').each((_, e) => { e.checked = false });
-      }
       window.location.reload();
     });
   });