Skip to content

Commit e95417e

Browse files
lafrikstechknowlogick
authored andcommitted
Fix column droping for MSSQL that need new transaction for that (#4440)
1 parent 659bc72 commit e95417e

File tree

2 files changed

+16
-0
lines changed

2 files changed

+16
-0
lines changed

models/migrations/v64.go

+8
Original file line numberDiff line numberDiff line change
@@ -120,6 +120,14 @@ func addMultipleAssignees(x *xorm.Engine) error {
120120
}
121121
}
122122

123+
// Commit and begin new transaction for dropping columns
124+
if err := sess.Commit(); err != nil {
125+
return err
126+
}
127+
if err := sess.Begin(); err != nil {
128+
return err
129+
}
130+
123131
if err := dropTableColumns(sess, "issue", "assignee_id"); err != nil {
124132
return err
125133
}

models/migrations/v69.go

+8
Original file line numberDiff line numberDiff line change
@@ -73,6 +73,14 @@ func moveTeamUnitsToTeamUnitTable(x *xorm.Engine) error {
7373
}
7474
}
7575

76+
// Commit and begin new transaction for dropping columns
77+
if err := sess.Commit(); err != nil {
78+
return err
79+
}
80+
if err := sess.Begin(); err != nil {
81+
return err
82+
}
83+
7684
if err := dropTableColumns(sess, "team", "unit_types"); err != nil {
7785
return err
7886
}

0 commit comments

Comments
 (0)