Skip to content

[Proposal] Make Gitea template system support context function #24228

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
Tracked by #23328
wxiaoguang opened this issue Apr 20, 2023 · 1 comment
Closed
Tracked by #23328

[Proposal] Make Gitea template system support context function #24228

wxiaoguang opened this issue Apr 20, 2023 · 1 comment
Labels
type/feature Completely new functionality. Can only be merged if feature freeze is not active. type/proposal The new feature has not been accepted yet but needs to be discussed first.

Comments

@wxiaoguang
Copy link
Contributor

wxiaoguang commented Apr 20, 2023 •
edited
Loading

Plan

After #24056, we have our own ScopedTemplate, which supports context functions.

This is a plan for next steps:

  • Wait for enough time to test and verify that our ScopedTemplate is stable enough
    • Maybe in about one month, use the edge build on gitea.com to eat our own dogfood
    • If there is anything wrong:
      • If it is fixable, improve the ScopedTemplate
      • If it is unfixable, revert to Golang's html/template (pity.....)
  • If Golang supports context function officially soon, switch to the official solution.

Then, if everything is fine:

  • Make locale use context function as the first refactoring step (maybe it, or maybe some other simple functions)
  • (TBC)
@wxiaoguang wxiaoguang added type/feature Completely new functionality. Can only be merged if feature freeze is not active. type/proposal The new feature has not been accepted yet but needs to be discussed first. labels Apr 20, 2023
This was referenced Apr 20, 2023
Closed
Closed
@wxiaoguang
Copy link
Contributor Author

Wait for Golang's official solution

https://go-review.googlesource.com/c/go/+/510738

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 6, 2023
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Assignees
No one assigned
Labels
type/feature Completely new functionality. Can only be merged if feature freeze is not active. type/proposal The new feature has not been accepted yet but needs to be discussed first.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@wxiaoguang