Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

contributors graph respect "Co-authored-by" #29183

Open
6543 opened this issue Feb 15, 2024 · 2 comments · May be fixed by #30925
Open

contributors graph respect "Co-authored-by" #29183

6543 opened this issue Feb 15, 2024 · 2 comments · May be fixed by #30925
Labels
type/enhancement An improvement of existing functionality

Comments

@6543
Copy link
Member

6543 commented Feb 15, 2024

the initial implementation ( #27882) does not use the Co-authored-by: information in commit messages.

but especially in repos like e.g. this one, where squash merge is used, you loose a lot of information.

func getExtendedCommitStats(repo *git.Repository, revision string /*, limit int */) ([]*ExtendedCommitStats, error) {

has to be extended ...

@6543 6543 added type/bug type/enhancement An improvement of existing functionality and removed type/bug labels Feb 15, 2024
@sahinakkaya
Copy link
Contributor

I actually didn't quite understand what you mean by that line of code has to be extended but I agree a lot of information is lost on squash. I always split my work into meaningful commits so that I could easily revert one of them if it is not needed or introduces a bug. It is not that easy to revert when they are squashed.

@6543
Copy link
Member Author

6543 commented Feb 16, 2024

@sahinakkaya that's not a critic of your work :)

it's a follow up issue that propose to also let authors count who are indicated by Co-authored-by keyword in commit messages :)

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants