From bef1abae39b274e23caf3256f9d4f8b02ecbfcad Mon Sep 17 00:00:00 2001 From: Lunny Xiao Date: Wed, 15 Nov 2023 09:55:43 +0800 Subject: [PATCH 1/6] Fix actions when tagging --- .github/workflows/release-tag-rc.yml | 4 ++++ .github/workflows/release-tag-version.yml | 4 ++++ 2 files changed, 8 insertions(+) diff --git a/.github/workflows/release-tag-rc.yml b/.github/workflows/release-tag-rc.yml index 861179d9c8652..fe94a0811b832 100644 --- a/.github/workflows/release-tag-rc.yml +++ b/.github/workflows/release-tag-rc.yml @@ -56,6 +56,10 @@ jobs: - name: upload binaries to s3 run: | aws s3 sync dist/release s3://${{ secrets.AWS_S3_BUCKET }}/gitea/${{ steps.clean_name.outputs.branch }} --no-progress + - name: Install GH CLI + uses: dev-hanz-ops/install-gh-cli-action + with: + gh-cli-version: 2.14.2 # optional, see action.yml for current default - name: create github release run: | gh release create ${{ github.ref_name }} --title ${{ github.ref_name }} --draft --notes-from-tag dist/release/* diff --git a/.github/workflows/release-tag-version.yml b/.github/workflows/release-tag-version.yml index c3fce7e2a7c58..431560b0d1586 100644 --- a/.github/workflows/release-tag-version.yml +++ b/.github/workflows/release-tag-version.yml @@ -58,6 +58,10 @@ jobs: - name: upload binaries to s3 run: | aws s3 sync dist/release s3://${{ secrets.AWS_S3_BUCKET }}/gitea/${{ steps.clean_name.outputs.branch }} --no-progress + - name: Install GH CLI + uses: dev-hanz-ops/install-gh-cli-action + with: + gh-cli-version: 2.14.2 # optional, see action.yml for current default - name: create github release run: | gh release create ${{ github.ref_name }} --title ${{ github.ref_name }} --draft --notes-from-tag dist/release/* From 0fb0401a3d6042ebd8322bd3419aff37b617a9d6 Mon Sep 17 00:00:00 2001 From: Lunny Xiao Date: Wed, 15 Nov 2023 10:07:50 +0800 Subject: [PATCH 2/6] remove draft parameter from gh release --- .github/workflows/release-tag-version.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/release-tag-version.yml b/.github/workflows/release-tag-version.yml index 431560b0d1586..f58d3605bafb5 100644 --- a/.github/workflows/release-tag-version.yml +++ b/.github/workflows/release-tag-version.yml @@ -64,7 +64,7 @@ jobs: gh-cli-version: 2.14.2 # optional, see action.yml for current default - name: create github release run: | - gh release create ${{ github.ref_name }} --title ${{ github.ref_name }} --draft --notes-from-tag dist/release/* + gh release create ${{ github.ref_name }} --title ${{ github.ref_name }} --notes-from-tag dist/release/* env: GITHUB_TOKEN: ${{ secrets.RELEASE_TOKEN }} docker-rootful: From 06498f894eb1fc0c002fcc5dac21a6c0c1d1bb2a Mon Sep 17 00:00:00 2001 From: Lunny Xiao Date: Wed, 15 Nov 2023 10:07:58 +0800 Subject: [PATCH 3/6] remove draft parameter from gh release --- .github/workflows/release-tag-rc.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/release-tag-rc.yml b/.github/workflows/release-tag-rc.yml index fe94a0811b832..a8b3f6882fd7d 100644 --- a/.github/workflows/release-tag-rc.yml +++ b/.github/workflows/release-tag-rc.yml @@ -62,7 +62,7 @@ jobs: gh-cli-version: 2.14.2 # optional, see action.yml for current default - name: create github release run: | - gh release create ${{ github.ref_name }} --title ${{ github.ref_name }} --draft --notes-from-tag dist/release/* + gh release create ${{ github.ref_name }} --title ${{ github.ref_name }} --notes-from-tag dist/release/* env: GITHUB_TOKEN: ${{ secrets.RELEASE_TOKEN }} docker-rootful: From 17072831054018a45b85041942e684af0c79b1f9 Mon Sep 17 00:00:00 2001 From: Lunny Xiao Date: Wed, 15 Nov 2023 10:11:02 +0800 Subject: [PATCH 4/6] Use default gh version --- .github/workflows/release-tag-rc.yml | 2 -- .github/workflows/release-tag-version.yml | 2 -- 2 files changed, 4 deletions(-) diff --git a/.github/workflows/release-tag-rc.yml b/.github/workflows/release-tag-rc.yml index a8b3f6882fd7d..db729b7df2140 100644 --- a/.github/workflows/release-tag-rc.yml +++ b/.github/workflows/release-tag-rc.yml @@ -58,8 +58,6 @@ jobs: aws s3 sync dist/release s3://${{ secrets.AWS_S3_BUCKET }}/gitea/${{ steps.clean_name.outputs.branch }} --no-progress - name: Install GH CLI uses: dev-hanz-ops/install-gh-cli-action - with: - gh-cli-version: 2.14.2 # optional, see action.yml for current default - name: create github release run: | gh release create ${{ github.ref_name }} --title ${{ github.ref_name }} --notes-from-tag dist/release/* diff --git a/.github/workflows/release-tag-version.yml b/.github/workflows/release-tag-version.yml index f58d3605bafb5..878a4a4f1ed9d 100644 --- a/.github/workflows/release-tag-version.yml +++ b/.github/workflows/release-tag-version.yml @@ -60,8 +60,6 @@ jobs: aws s3 sync dist/release s3://${{ secrets.AWS_S3_BUCKET }}/gitea/${{ steps.clean_name.outputs.branch }} --no-progress - name: Install GH CLI uses: dev-hanz-ops/install-gh-cli-action - with: - gh-cli-version: 2.14.2 # optional, see action.yml for current default - name: create github release run: | gh release create ${{ github.ref_name }} --title ${{ github.ref_name }} --notes-from-tag dist/release/* From eb4d8b18c32c49573b9f491d7083325c41e561ff Mon Sep 17 00:00:00 2001 From: Lunny Xiao Date: Wed, 15 Nov 2023 10:51:39 +0800 Subject: [PATCH 5/6] Fix actions lint --- .github/workflows/release-tag-rc.yml | 4 +++- .github/workflows/release-tag-version.yml | 4 +++- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/.github/workflows/release-tag-rc.yml b/.github/workflows/release-tag-rc.yml index db729b7df2140..f7cc770f19cb1 100644 --- a/.github/workflows/release-tag-rc.yml +++ b/.github/workflows/release-tag-rc.yml @@ -57,7 +57,9 @@ jobs: run: | aws s3 sync dist/release s3://${{ secrets.AWS_S3_BUCKET }}/gitea/${{ steps.clean_name.outputs.branch }} --no-progress - name: Install GH CLI - uses: dev-hanz-ops/install-gh-cli-action + uses: dev-hanz-ops/install-gh-cli-action@v0.1.0 + with: + gh-cli-version: 2.39.1 - name: create github release run: | gh release create ${{ github.ref_name }} --title ${{ github.ref_name }} --notes-from-tag dist/release/* diff --git a/.github/workflows/release-tag-version.yml b/.github/workflows/release-tag-version.yml index 878a4a4f1ed9d..94d38ff035874 100644 --- a/.github/workflows/release-tag-version.yml +++ b/.github/workflows/release-tag-version.yml @@ -59,7 +59,9 @@ jobs: run: | aws s3 sync dist/release s3://${{ secrets.AWS_S3_BUCKET }}/gitea/${{ steps.clean_name.outputs.branch }} --no-progress - name: Install GH CLI - uses: dev-hanz-ops/install-gh-cli-action + uses: dev-hanz-ops/install-gh-cli-action@v0.1.0 + with: + gh-cli-version: 2.39.1 - name: create github release run: | gh release create ${{ github.ref_name }} --title ${{ github.ref_name }} --notes-from-tag dist/release/* From d99c4ada57a002c4c020955c8a92dad348ae0d30 Mon Sep 17 00:00:00 2001 From: techknowlogick Date: Sat, 25 Nov 2023 13:44:55 -0500 Subject: [PATCH 6/6] Update .github/workflows/release-tag-rc.yml --- .github/workflows/release-tag-rc.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/release-tag-rc.yml b/.github/workflows/release-tag-rc.yml index f7cc770f19cb1..bb839cb655048 100644 --- a/.github/workflows/release-tag-rc.yml +++ b/.github/workflows/release-tag-rc.yml @@ -62,7 +62,7 @@ jobs: gh-cli-version: 2.39.1 - name: create github release run: | - gh release create ${{ github.ref_name }} --title ${{ github.ref_name }} --notes-from-tag dist/release/* + gh release create ${{ github.ref_name }} --title ${{ github.ref_name }} --draft --notes-from-tag dist/release/* env: GITHUB_TOKEN: ${{ secrets.RELEASE_TOKEN }} docker-rootful: