From 1747426f8d6341306d8747ed21951591f3ea9bba Mon Sep 17 00:00:00 2001 From: Lunny Xiao Date: Sat, 18 Nov 2023 22:33:47 +0800 Subject: [PATCH 1/5] Fix empty action run title --- templates/repo/actions/runs_list.tmpl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/templates/repo/actions/runs_list.tmpl b/templates/repo/actions/runs_list.tmpl index b3469a2edc3ed..f2049cff8197f 100644 --- a/templates/repo/actions/runs_list.tmpl +++ b/templates/repo/actions/runs_list.tmpl @@ -12,7 +12,7 @@
- {{- .Title -}} + {{if .Title}}{{- .Title -}}{{else}}{{end}}
{{if not $.CurWorkflow}}{{.WorkflowID}} {{end}}#{{.Index}}: From 648bba039fd1f63bbe8b4e80960d9c1b333f0c07 Mon Sep 17 00:00:00 2001 From: Lunny Xiao Date: Sat, 18 Nov 2023 22:39:28 +0800 Subject: [PATCH 2/5] Fix template --- templates/repo/actions/runs_list.tmpl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/templates/repo/actions/runs_list.tmpl b/templates/repo/actions/runs_list.tmpl index f2049cff8197f..514349a176e27 100644 --- a/templates/repo/actions/runs_list.tmpl +++ b/templates/repo/actions/runs_list.tmpl @@ -12,7 +12,7 @@
- {{if .Title}}{{- .Title -}}{{else}}{{end}} + {{if .Title}}{{- .Title -}}{{else}}<empty commit message>{{end}}
{{if not $.CurWorkflow}}{{.WorkflowID}} {{end}}#{{.Index}}: From b66a356d44affc649e58c94ea70458485477d993 Mon Sep 17 00:00:00 2001 From: Lunny Xiao Date: Mon, 20 Nov 2023 16:41:19 +0800 Subject: [PATCH 3/5] translation --- options/locale/locale_en-US.ini | 1 + templates/repo/actions/runs_list.tmpl | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/options/locale/locale_en-US.ini b/options/locale/locale_en-US.ini index a7a7a4f4c50f9..2bd6703cbf5fb 100644 --- a/options/locale/locale_en-US.ini +++ b/options/locale/locale_en-US.ini @@ -3529,6 +3529,7 @@ runs.actors_no_select = All actors runs.status_no_select = All status runs.no_results = No results matched. runs.no_runs = The workflow has no runs yet. +runs.no_commit_message = empty commit message workflow.disable = Disable Workflow workflow.disable_success = Workflow '%s' disabled successfully. diff --git a/templates/repo/actions/runs_list.tmpl b/templates/repo/actions/runs_list.tmpl index 514349a176e27..43964bfe70016 100644 --- a/templates/repo/actions/runs_list.tmpl +++ b/templates/repo/actions/runs_list.tmpl @@ -12,7 +12,7 @@
- {{if .Title}}{{- .Title -}}{{else}}<empty commit message>{{end}} + {{if .Title}}{{- .Title -}}{{else}}<{{ctx.Locale.Tr "actions.runs.no_commit_message"}}>{{end}}
{{if not $.CurWorkflow}}{{.WorkflowID}} {{end}}#{{.Index}}: From 1e31b1e09b2d0feec67612aad3f83c0cc8c34099 Mon Sep 17 00:00:00 2001 From: Lunny Xiao Date: Tue, 21 Nov 2023 09:29:28 +0800 Subject: [PATCH 4/5] Follow @silverwind's suggestion --- options/locale/locale_en-US.ini | 2 +- templates/repo/actions/runs_list.tmpl | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/options/locale/locale_en-US.ini b/options/locale/locale_en-US.ini index 77160aa5b99b0..123034665cc42 100644 --- a/options/locale/locale_en-US.ini +++ b/options/locale/locale_en-US.ini @@ -3530,7 +3530,7 @@ runs.actors_no_select = All actors runs.status_no_select = All status runs.no_results = No results matched. runs.no_runs = The workflow has no runs yet. -runs.no_commit_message = empty commit message +runs.empty_commit_message = empty commit message workflow.disable = Disable Workflow workflow.disable_success = Workflow '%s' disabled successfully. diff --git a/templates/repo/actions/runs_list.tmpl b/templates/repo/actions/runs_list.tmpl index 43964bfe70016..b174f762ecc33 100644 --- a/templates/repo/actions/runs_list.tmpl +++ b/templates/repo/actions/runs_list.tmpl @@ -12,7 +12,7 @@
- {{if .Title}}{{- .Title -}}{{else}}<{{ctx.Locale.Tr "actions.runs.no_commit_message"}}>{{end}} + {{if .Title}}{{- .Title -}}{{else}}<{{ctx.Locale.Tr "actions.runs.empty_commit_message"}}>{{end}}
{{if not $.CurWorkflow}}{{.WorkflowID}} {{end}}#{{.Index}}: From 6f3060f9807867ea2c05e2101fcb3652fafe4208 Mon Sep 17 00:00:00 2001 From: Lunny Xiao Date: Tue, 21 Nov 2023 10:11:52 +0800 Subject: [PATCH 5/5] Follow @wxiaoguang's sugguestion --- options/locale/locale_en-US.ini | 2 +- templates/repo/actions/runs_list.tmpl | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/options/locale/locale_en-US.ini b/options/locale/locale_en-US.ini index 6b7ec8515849c..293316fc7b923 100644 --- a/options/locale/locale_en-US.ini +++ b/options/locale/locale_en-US.ini @@ -3530,7 +3530,7 @@ runs.actors_no_select = All actors runs.status_no_select = All status runs.no_results = No results matched. runs.no_runs = The workflow has no runs yet. -runs.empty_commit_message = empty commit message +runs.empty_commit_message = (empty commit message) workflow.disable = Disable Workflow workflow.disable_success = Workflow '%s' disabled successfully. diff --git a/templates/repo/actions/runs_list.tmpl b/templates/repo/actions/runs_list.tmpl index b174f762ecc33..3b289fb68f2ea 100644 --- a/templates/repo/actions/runs_list.tmpl +++ b/templates/repo/actions/runs_list.tmpl @@ -12,7 +12,7 @@
- {{if .Title}}{{- .Title -}}{{else}}<{{ctx.Locale.Tr "actions.runs.empty_commit_message"}}>{{end}} + {{if .Title}}{{.Title}}{{else}}{{ctx.Locale.Tr "actions.runs.empty_commit_message"}}{{end}}
{{if not $.CurWorkflow}}{{.WorkflowID}} {{end}}#{{.Index}}: