-
Notifications
You must be signed in to change notification settings - Fork 97
Add os.listdir #216
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Add os.listdir #216
Conversation
Please take a review, thanks |
Codecov ReportBase: 74.38% // Head: 74.38% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #216 +/- ##
==========================================
- Coverage 74.38% 74.38% -0.01%
==========================================
Files 76 76
Lines 12625 12656 +31
==========================================
+ Hits 9391 9414 +23
- Misses 2562 2567 +5
- Partials 672 675 +3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the PR.
I have a couple of comments.
see below.
Perhaps :-) |
Oh, I see..
Perhaps need a comment to show that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
could you please send another PR against go-python/license, adding yourself to the AUTHORS
and/or CONTRIBUTORS
files ?
thanks.
Here is the PR for contributors go-python/license#20 . |
No description provided.