Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

chore: adding importas linter #103

Closed
ccoVeille opened this issue Dec 12, 2024 · 1 comment · Fixed by #94
Closed

chore: adding importas linter #103

ccoVeille opened this issue Dec 12, 2024 · 1 comment · Fixed by #94
Assignees
@ccoVeille
Labels
priority/low 🟩 Priority 4 - Low priority and doesn't need to be rushed

Comments

@ccoVeille
Copy link
Contributor

ccoVeille commented Dec 12, 2024 •
edited
Loading

importas linter could be used tu enforce using registry time as rtime, and std time as time.

If you decide to reverse the logic like that can you check we don't have another "std import with alias" on the codebase to be consistant please
Originally posted by @42atomys in #94 (comment)
@ccoVeille ccoVeille added priority/low 🟩 Priority 4 - Low priority and doesn't need to be rushed type/chore 🛠 Code changes that neither fix bugs nor add features (refactoring, dependency changes, ...) labels Dec 12, 2024
@42atomys 42atomys mentioned this issue Dec 12, 2024
Merged
6 tasks
@42atomys 42atomys changed the title Consider adding importas linter chore: adding importas linter Dec 12, 2024
@42atomys 42atomys removed the type/chore 🛠 Code changes that neither fix bugs nor add features (refactoring, dependency changes, ...) label Dec 12, 2024
@42atomys 42atomys linked a pull request Dec 12, 2024 that will close this issue
fix(date): use available timezone if any #94
Merged
6 tasks
@ccoVeille
Copy link
Contributor Author

A fix was provided for importas

golangci/golangci-lint#5222

We will be able to enforce to have no alias for for std packages time, strings and co

Something I wasn't able to do yet.

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@ccoVeille ccoVeille

Labels
priority/low 🟩 Priority 4 - Low priority and doesn't need to be rushed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(date): use available timezone if any go-sprout/sprout
2 participants
@ccoVeille @42atomys