Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add get_noise_1d() to OpenSimplexNoise #26457

Closed
Shadowblitz16 opened this issue Mar 1, 2019 · 4 comments
Closed

Add get_noise_1d() to OpenSimplexNoise #26457

Shadowblitz16 opened this issue Mar 1, 2019 · 4 comments

Comments

@Shadowblitz16
Copy link

Godot version: 3.1 beta 8
Windows 7 home 64 bit

Please add get_noise_1d() to OpenSimplexNoise.
Also please give us the equivalent all the noise get functions that return 0-1 range instead of -1-1.

@hpvb hpvb added this to the 3.2 milestone Mar 1, 2019
@psuhas77
Copy link
Contributor

psuhas77 commented Mar 3, 2019

Hey, I want to try working on this. The simplest solution would be to create get_noise_1d(float x) which simply returns get_noise_2d(float x,float fixedValue) Is there some reason why this would be problematic?

@akien-mga akien-mga changed the title get_noise_1d() Add get_noise_1d() to OpenSimplexNoise Mar 3, 2019
@akien-mga
Copy link
Member

CC @JFonS

@psuhas77
Copy link
Contributor

psuhas77 commented Mar 3, 2019

So, this is what I got after using get_noise_2d(float x,float(1)) with default octaves,lacunarity,persistence and period. Each frame represents a different seed. It seems to behave like 1D Simplex noise should.

@Chaosus
Copy link
Member

Chaosus commented Mar 4, 2019

Yeah, its simply noise2D(x, 1.0), and its not very useful for SimplexNoises as described in jwagner/simplex-noise.js#16
But its a good PR training for @psuhas77 - you could easily implement this if you want :)

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

No branches or pull requests

5 participants