New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

missing UnimplementedXxxServer from upstream #628

Open

carnott-snap opened this issue Sep 17, 2019 · 2 comments

carnott-snap commented Sep 17, 2019

golang/protobuf#875 recently added support for an UnimplementedXxxServer struct, to offer forward compatibility when implementing the generated XxxServer interface[0]. This was released as part of their v1.3.2 release.

I see that #191 tracks upstream merges, per the README.md, but there has been no discussion since December 2019, so I thought I would try and track this separately.

0] See grpc ticket: grpc/grpc-go#2318

The text was updated successfully, but these errors were encountered:

Contributor

jmarais commented Oct 11, 2019

Hi, Are you referring to this commit:
golang/protobuf@b85cd75
?

Author

carnott-snap commented Oct 11, 2019

Yes, that should be the change. I think this has been merged in now, but I would need to double check.

# for free to join this conversation on GitHub. Already have an account? # to comment