From f22f102654f74a8a09f7b4de64c24a8f8dac93b5 Mon Sep 17 00:00:00 2001 From: Tan Jiang Date: Wed, 28 Sep 2016 14:36:09 +0800 Subject: [PATCH] refresh cache and insert repo to DB should be in one goroutine --- service/notification.go | 17 ++++------------- 1 file changed, 4 insertions(+), 13 deletions(-) diff --git a/service/notification.go b/service/notification.go index b5d32f5edf0..da6825c01bd 100644 --- a/service/notification.go +++ b/service/notification.go @@ -71,12 +71,6 @@ func (n *NotificationHandler) Post() { } }() if action == "push" { - go func() { - if err := cache.RefreshCatalogCache(); err != nil { - log.Errorf("failed to refresh cache: %v", err) - } - }() - go func() { exist := dao.RepositoryExists(repository) if exist { @@ -87,14 +81,11 @@ func (n *NotificationHandler) Post() { if err := dao.AddRepository(repoRecord); err != nil { log.Errorf("Error happens when adding repository: %v", err) } + if err := cache.RefreshCatalogCache(); err != nil { + log.Errorf("failed to refresh cache: %v", err) + } }() - - operation := "" - if action == "push" { - operation = models.RepOpTransfer - } - - go api.TriggerReplicationByRepository(repository, []string{tag}, operation) + go api.TriggerReplicationByRepository(repository, []string{tag}, models.RepOpTransfer) } if action == "pull" { go func() {