Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

prepare redis tls config #21667

Merged
merged 1 commit into from
Feb 27, 2025
Merged

Conversation

MinerYang
Copy link
Contributor

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

21632

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@MinerYang MinerYang added the target/2.13.0 issues that are targeting v2.13.0 label Feb 25, 2025
@MinerYang MinerYang requested a review from a team as a code owner February 25, 2025 04:11
Copy link

codecov bot commented Feb 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.35%. Comparing base (c8c11b4) to head (d9bf12b).
Report is 396 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #21667      +/-   ##
==========================================
+ Coverage   45.36%   46.35%   +0.99%     
==========================================
  Files         244      249       +5     
  Lines       13333    14047     +714     
  Branches     2719     2897     +178     
==========================================
+ Hits         6049     6512     +463     
- Misses       6983     7192     +209     
- Partials      301      343      +42     
Flag Coverage Δ
unittests 46.35% <ø> (+0.99%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 493 files with indirect coverage changes

@MinerYang MinerYang force-pushed the add_prepare_redis_tls branch from 1c3dd19 to 52016d5 Compare February 25, 2025 04:13
@MinerYang MinerYang added the release-note/update Update or Fix label Feb 25, 2025
@MinerYang MinerYang changed the title add prepare for redis tls config prepare redis tls config Feb 25, 2025
@MinerYang MinerYang force-pushed the add_prepare_redis_tls branch from 52016d5 to d11313b Compare February 25, 2025 06:28
Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@MinerYang MinerYang force-pushed the add_prepare_redis_tls branch 2 times, most recently from f64d487 to 89fd6b4 Compare February 27, 2025 07:38
Signed-off-by: yminer <miner.yang@broadcom.com>
@MinerYang MinerYang force-pushed the add_prepare_redis_tls branch from 89fd6b4 to d9bf12b Compare February 27, 2025 07:46
@MinerYang MinerYang merged commit 5c39e76 into goharbor:main Feb 27, 2025
12 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
release-note/update Update or Fix target/2.13.0 issues that are targeting v2.13.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants