-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
prepare redis tls config #21667
Merged
Merged
prepare redis tls config #21667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #21667 +/- ##
==========================================
+ Coverage 45.36% 46.35% +0.99%
==========================================
Files 244 249 +5
Lines 13333 14047 +714
Branches 2719 2897 +178
==========================================
+ Hits 6049 6512 +463
- Misses 6983 7192 +209
- Partials 301 343 +42
Flags with carried forward coverage won't be shown. Click here to find out more. |
1c3dd19
to
52016d5
Compare
stonezdj
reviewed
Feb 25, 2025
stonezdj
reviewed
Feb 25, 2025
stonezdj
reviewed
Feb 25, 2025
52016d5
to
d11313b
Compare
chlins
approved these changes
Feb 26, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
stonezdj
approved these changes
Feb 26, 2025
f64d487
to
89fd6b4
Compare
Signed-off-by: yminer <miner.yang@broadcom.com>
89fd6b4
to
d9bf12b
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to Harbor!
Comprehensive Summary of your change
Issue being fixed
21632
Please indicate you've done the following: