Skip to content

Commit bdde41e

Browse files
committed
runtime: skip TestGdbBacktrace on gdb bug
Very rarely, GDB will successfully run the whole test and the inferior will exit successfully, and then GDB itself hangs and never exits. Detect this and skip the test as flaky. We could just continue the test since all of the output we need is there, but by skipping it we're less likely to notice serious regressions in this test. Fixes #37405. Change-Id: I016cbb06f48673f064733da3e3f1ddcbefd58159 Reviewed-on: https://go-review.googlesource.com/c/go/+/411117 Reviewed-by: Cherry Mui <cherryyz@google.com>
1 parent 432158b commit bdde41e

File tree

1 file changed

+5
-0
lines changed

1 file changed

+5
-0
lines changed

src/runtime/runtime-gdb_test.go

+5
Original file line numberDiff line numberDiff line change
@@ -435,6 +435,11 @@ func TestGdbBacktrace(t *testing.T) {
435435
// GDB bug: https://sourceware.org/bugzilla/show_bug.cgi?id=9086
436436
testenv.SkipFlaky(t, 50838)
437437
}
438+
if bytes.Contains(got, []byte(" exited normally]\n")) {
439+
// GDB bug: Sometimes the inferior exits fine,
440+
// but then GDB hangs.
441+
testenv.SkipFlaky(t, 37405)
442+
}
438443
t.Fatalf("gdb exited with error: %v", err)
439444
}
440445

0 commit comments

Comments
 (0)