-
Notifications
You must be signed in to change notification settings - Fork 17.8k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
x/tools/go/ssa: panic: no ssa.Value for function argument #33279
Comments
/cc @matloob |
I can reproduce this: I build ssadump with go1.13 and ran it on the test file and it panicked. But I can't reproduce it with a version of ssadump built with tip (go version devel +47efbf0a4e Wed Oct 30 00:41:31 2019 +0000 darwin/amd64). I wonder why that is |
The following commit fixed the crash:
It should've been a behavior-preserving change, but it wasn't. Pinging @griesemer to inquire if the code in the original comment would be something that might be type-checked differently before and after the commit. Edit: edited to ping our @griesemer and not an imposter :-) |
What did you do?
Input program:
Run
ssadump
on the package.The panic does not occur if the result of the function call or of the indexing operation are stored in a temporary variable before doing the post-increment.
What did you expect to see?
No panic.
What did you see instead?
/cc @ianthehat
The text was updated successfully, but these errors were encountered: