Skip to content

api: audit for Go 1.23 #67843

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
gopherbot opened this issue Jun 5, 2024 · 4 comments
Closed

api: audit for Go 1.23 #67843

gopherbot opened this issue Jun 5, 2024 · 4 comments
Labels
ExpertNeeded NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. release-blocker
Milestone

Comments

@gopherbot
Copy link
Contributor

This is a tracking issue for doing an audit of API additions for Go 1.23 as of CL 590835.

New API changes for Go 1.23

archive/tar

crypto/tls

crypto/x509

debug/elf

encoding/binary

go/ast

go/types

iter

maps

math/rand/v2

net

net/http

net/http/httptest

os

path/filepath

reflect

runtime/debug

slices

structs

sync

sync/atomic

syscall (windows-386)

syscall (windows-amd64)

unicode/utf16

unique

CC @rsc, @ianlancetaylor, @golang/release.

@gopherbot gopherbot added ExpertNeeded NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. release-blocker labels Jun 5, 2024
@gopherbot gopherbot added this to the Go1.23 milestone Jun 5, 2024
@dmitshur dmitshur moved this to Todo in Release Blockers Jun 5, 2024
@rsc
Copy link
Contributor

rsc commented Jun 6, 2024

Reading through the list, these all LGTM, meaning I remember the proposals and still think that the APIs are correct.
Would be good for @ianlancetaylor to check the same, and then I think we can close this. Thanks!

@dmitshur dmitshur moved this from Todo to In Progress in Release Blockers Jun 6, 2024
@dmitshur
Copy link
Contributor

dmitshur commented Jun 8, 2024

I also looked a bit at the proposed and implemented APIs. Everything seems to align. The WSAENOPROTOOPT constant wasn't mentioned in proposal #62254, but it seems fine.

@ianlancetaylor
Copy link
Member

I have also reviewed. LGTM.

@github-project-automation github-project-automation bot moved this from In Progress to Done in Release Blockers Jun 9, 2024
@dmitshur
Copy link
Contributor

dmitshur commented Aug 7, 2024

For posterity: the type QUICConfig struct, EnableStoreSessionEvent bool field has since been renamed to EnableSessionEvents after a deliberate decision in #68124.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
ExpertNeeded NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. release-blocker
Projects
Status: Done
Development

No branches or pull requests

4 participants