x/pkgsite/cmd/pkgsite: invalid env set

[vkml]

What is the URL of the page with the issue?

any module URL

What is your user agent?

Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/131.0.0.0 Safari/537.36

Screenshot

No response

What did you do?

Ran the pkgsite command to run the server. Exact used command syntax: pkgsite -http=":7000"

What did you see happen?

On Windows, running the command for the local repository starts the server but fails and hands indefinitely when attempting to follow the module tree. During server init the following error is displayed:
Error: loading packages from stdlib: err: fork/exec E:\LANG\Go\bin\go.exe: The parameter is incorrect.: stderr:

The godoc command works fine on the same local project.

What did you expect to see?

Local project documentation.

[gabyhelp]

Related Issues

• x/pkgsite/cmd/pkgsite: Unable to fetch std@Latest Pkgsite documentation for Local Main go Repo : https://go.googlesource.com/go #63744
• x/pkgsite: cmd line tool panics with panic: http: multiple registrations for <pwd> #53323 (closed)
• x/pkgsite: request for documentation for non-std modules responds with an error #51368 (closed)
• x/pkgsite/cmd/pkgsite: panic for "multiple registrations" when running locally #64903 (closed)
• x/pkgsite/cmd/pkgsite: templates aren't embedded, causing an error if run from another directory #48410 (closed)

_{(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)}

[vkml]

Found the possible reason for the following error:

Error: loading packages from stdlib: err: fork/exec E:\LANG\Go\bin\go.exe: The parameter is incorrect.: stderr:

Internal go list ... command call fails due to function NewGoPackagesStdlibModuleGetter(...) sets a malformed env variable. It tries to append env strings slice with "GOROOT=" and abs, which results in 2 separate slice elements, but the intended behavior would be "GOROOT=" + abs to set GOROOT.

[findleyr]

CC @matloob

[matloob]

This was fixed by https://go.dev/cl/635675.