Skip to content
This repository has been archived by the owner on Jun 27, 2023. It is now read-only.

Fix empty error message when call is exhausted #460

Merged
merged 2 commits into from
Aug 21, 2020

Conversation

cvgw
Copy link
Collaborator

@cvgw cvgw commented Jul 24, 2020

Fixes #404
Description

Fix empty error messages when the received call is exhausted

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests

Reviewer Notes

  • The code flow looks good.
  • Tests added.

Release Notes

Describe any changes here so maintainer can include it in the release notes, or delete this block.

Fix empty error message when expected method has been called too many times

@cvgw cvgw force-pushed the cgwippern/404_empty_msg_for_exhausted_calls branch from 7897399 to f001613 Compare July 24, 2020 21:38
@cvgw cvgw force-pushed the cgwippern/404_empty_msg_for_exhausted_calls branch from f001613 to aa9e21c Compare July 24, 2020 21:39
@cvgw cvgw requested a review from codyoss July 24, 2020 21:40
gomock/callset.go Outdated Show resolved Hide resolved
error message update

Co-authored-by: Cody Oss <6331106+codyoss@users.noreply.github.com>
@cvgw cvgw requested a review from codyoss August 21, 2020 20:21
@cvgw
Copy link
Collaborator Author

cvgw commented Aug 21, 2020

PTAL

# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix callserrors with empty msg
2 participants