Skip to content
This repository has been archived by the owner on Jun 27, 2023. It is now read-only.

mockgen: record invocation arguments in generated code #554

Open
rogpeppe opened this issue May 12, 2021 · 1 comment · Fixed by uber-go/mock#31 · May be fixed by #702
Open

mockgen: record invocation arguments in generated code #554

rogpeppe opened this issue May 12, 2021 · 1 comment · Fixed by uber-go/mock#31 · May be fixed by #702
Labels
help wanted type: feature request

Comments

@rogpeppe
Copy link

It's not always obvious how mockgen-generated code has been created,
particularly when coming to it without prior knowledge of it. Good practice
would be to include a go:generate directive that can be used to regenerate
the code, but that's not always done.

Currently the comments on the generated code look something like this:

// Code generated by MockGen. DO NOT EDIT.
// Source: github.com/foo/bar (interfaces: Baz)

// Package mocks is a generated GoMock package.

I propose something along the lines of this:

// Code generated by MockGen. DO NOT EDIT.
// Source: github.com/foo/bar (interfaces: Baz)
//
// Generated by this command:
//    gomock github.com/foo/bar Baz

// Package mocks is a generated GoMock package.
@codyoss
Copy link
Member

codyoss commented May 14, 2021

Hey, thanks for the feature request, I like this idea! I think it would also be useful to record what version of mockgen generated the mock as well.

I would be happy to accept a PR for such a feature 😃

This was referenced Jun 12, 2021
Closed
Closed
kucherenkovova pushed a commit to kucherenkovova/mock that referenced this issue Apr 30, 2023
record invocation arguments in generated code
0b124ea 
resolves golang#554
kucherenkovova added a commit to kucherenkovova/mock that referenced this issue Apr 30, 2023
@kucherenkovova
record invocation arguments in generated code
882955c 
resolves golang#554
@kucherenkovova kucherenkovova linked a pull request Apr 30, 2023 that will close this issue
Open
kucherenkovova added a commit to kucherenkovova/mock that referenced this issue Jul 10, 2023
@kucherenkovova
record invocation arguments in generated code
f7ed795 
resolves golang#554
@kucherenkovova kucherenkovova mentioned this issue Jul 10, 2023
Merged
kucherenkovova added a commit to kucherenkovova/mock that referenced this issue Jul 12, 2023
@kucherenkovova
record invocation arguments in generated code
09dd178 
resolves golang#554
@skitt skitt mentioned this issue Oct 5, 2023
Merged
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Assignees
No one assigned
Labels
help wanted type: feature request
Projects
None yet
Milestone
No milestone
2 participants
@rogpeppe @codyoss